Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTCR Factory: Allow upgradable contract code. #14

Closed
eccentricexit opened this issue Jan 27, 2020 · 1 comment
Closed

GTCR Factory: Allow upgradable contract code. #14

eccentricexit opened this issue Jan 27, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@eccentricexit
Copy link
Contributor

eccentricexit commented Jan 27, 2020

Currently the GTCR Factory simply keeps a copy of a version of the GTCR and deploys it. This has the downside that the version of the GTCR code to deploy is locked. New versions would require a new factory.

Instead, we can have the factory store the address of a GTCR instance. deploy() would then copy the code and deploy from that.

If the GTCR code is ever updated, we can update the address of the "blueprint" GTCR so that new versions can be deployed using the same factory.

@eccentricexit eccentricexit added the enhancement New feature or request label Jan 27, 2020
@eccentricexit eccentricexit self-assigned this Jan 27, 2020
@eccentricexit
Copy link
Contributor Author

As discussed in call, this feature adds complexity (and thus harms security). Instead cloning contract, we can deploy a new factory and reference the previous one from the new contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant