Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change transferFrom to transfer on send ETH #35

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

jxnata
Copy link
Contributor

@jxnata jxnata commented Feb 7, 2024

Description

When sending some tokens on the Ethereum network, allowance errors were occurring due to the use of the transferFrom function, which requires prior approval.
I changed it to the ERC-20 transfer() function to avoid these errors.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have confirmed all checks make check

@jxnata jxnata merged commit 5800202 into develop Feb 7, 2024
3 of 4 checks passed
brunocampos-ssa added a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants