-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize tx into raw hex trx #44
Conversation
WalkthroughOur latest update introduces significant improvements across various modules of the Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…rialize-tx-into-raw-hex-trx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/kos-sdk/src/chains/tron/mod.rs (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/kos-sdk/src/chains/tron/mod.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/kos-sdk/src/chains/tron/mod.rs (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/kos-sdk/src/chains/tron/mod.rs
…kos-rs into serialize-tx-into-raw-hex-trx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Outside diff range and nitpick comments (1)
packages/kos-sdk/src/chains/ethereum/mod.rs (1)
480-480
: Ensure proper environment variable management and test initialization.Consider adding error handling for
dotenv::from_filename(".env.nodes").ok();
to ensure that the environment file is loaded correctly and log any errors if the file is not found or has incorrect formatting.Also applies to: 483-483, 491-497
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
Files selected for processing (6)
- Cargo.toml (2 hunks)
- packages/kos-sdk/Cargo.toml (1 hunks)
- packages/kos-sdk/src/chains/bitcoin/mod.rs (3 hunks)
- packages/kos-sdk/src/chains/bitcoin/requests.rs (2 hunks)
- packages/kos-sdk/src/chains/ethereum/mod.rs (2 hunks)
- packages/kos-sdk/src/chains/klever/klever_test.rs (8 hunks)
Files skipped from review due to trivial changes (2)
- Cargo.toml
- packages/kos-sdk/Cargo.toml
Additional comments not posted (3)
packages/kos-sdk/src/chains/bitcoin/requests.rs (1)
169-169
: Repeated issue: Hardcoded URL should be dynamically retrieved.packages/kos-sdk/src/chains/ethereum/mod.rs (2)
480-480
: Initialization of environment variables is well-implemented using theOnce
pattern.This ensures that environment settings are loaded exactly once, which is crucial for consistent test execution.
Also applies to: 483-483, 491-497
Line range hint
480-621
: The test suite is comprehensive and well-structured.Great job ensuring thorough coverage of Ethereum functionalities and proper initialization of environment settings for consistent test execution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
Files selected for processing (4)
- packages/kos-sdk/Cargo.toml (1 hunks)
- packages/kos-sdk/src/chains/bitcoin/mod.rs (3 hunks)
- packages/kos-sdk/src/chains/ethereum/mod.rs (2 hunks)
- packages/kos-sdk/src/chains/klever/klever_test.rs (8 hunks)
Files skipped from review as they are similar to previous changes (4)
- packages/kos-sdk/Cargo.toml
- packages/kos-sdk/src/chains/bitcoin/mod.rs
- packages/kos-sdk/src/chains/ethereum/mod.rs
- packages/kos-sdk/src/chains/klever/klever_test.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/pull-develop.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/pull-develop.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/pull-develop.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/pull-develop.yaml
Description
Added TRX raw_data serialization
Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
make check
Summary by CodeRabbit
New Features
Bug Fixes
Chores