Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to laminas http #98

Closed
wants to merge 1 commit into from
Closed

Conversation

TheWhisp
Copy link

@TheWhisp TheWhisp commented Feb 7, 2024

laminas/laminas-server (2.17.0) drops requirement for laminas/laminas-zendframework-bridge (which is abandoned now)

@klevu
Copy link
Owner

klevu commented Feb 16, 2024

@TheWhisp Thank you for reporting this and providing the pull request.

I have released a new version of the module to handle this issue.
We didn't use your pull request (though it looked perfectly good) as the 3.x branch of this module supports Magento 2.3 and 2.4. We may still have some merchants running Magento versions prior to 2.3.5 when Laminas was introduced.

With this in mind, we have created a new module which merchants on older versions can remove via Composer replace.
This new module replaces Zend with Laminas. The new module is automatically included when upgrading to 3.5.0.

This new module can be found here https://github.com/klevu/api-request.
and is required here https://github.com/klevu/productsearch/blob/3.x/composer.json#L14

We have added a Knowledge Base article for this issue with an explanation as to which versions of our module will support this change going forward. https://help.klevu.com/support/solutions/articles/5000887379-http-client-change-zend-to-laminas

Kind Regards,
Richard.

@klevu
Copy link
Owner

klevu commented Feb 19, 2024

Closing this PR as a fix has been released.
There is a related (closed) issue which we will keep pinned for visibility.
#97

@klevu klevu closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants