-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search engine #12
Search engine #12
Conversation
… into search-engine
… into search-engine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, it just looks like the package-lock.json file is still included in the PR, not sure if it should be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have a couple suggestions for small changes/cleanup before merging to the main branch.
-Remove lines 91-94 (tagInput & tagOptions). I accidentally left these in my tag-filter-branch but they're not used and unnecessary now.
-Make the search case-insensitive: Just add .toLowerCase to the text input & the common/latin name checks. Probably wont need to do this for other filter categories since we will be mostly using predefined icons.
I've changed both now, thanks. |
Merged search-engine, tailwind and cloudinary with master branch, should be no conflicts, maybe slight differences in position of code in config files but I would like to check with the team first