Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search engine #12

Merged
merged 10 commits into from
Aug 27, 2023
Merged

Search engine #12

merged 10 commits into from
Aug 27, 2023

Conversation

joel-yap
Copy link
Collaborator

Merged search-engine, tailwind and cloudinary with master branch, should be no conflicts, maybe slight differences in position of code in config files but I would like to check with the team first

Copy link
Collaborator

@EmilyClare4 EmilyClare4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it just looks like the package-lock.json file is still included in the PR, not sure if it should be?

Copy link
Collaborator

@AdamN2424 AdamN2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a couple suggestions for small changes/cleanup before merging to the main branch.

-Remove lines 91-94 (tagInput & tagOptions). I accidentally left these in my tag-filter-branch but they're not used and unnecessary now.
-Make the search case-insensitive: Just add .toLowerCase to the text input & the common/latin name checks. Probably wont need to do this for other filter categories since we will be mostly using predefined icons.

@joel-yap
Copy link
Collaborator Author

Looks good, I just have a couple suggestions for small changes/cleanup before merging to the main branch.

-Remove lines 91-94 (tagInput & tagOptions). I accidentally left these in my tag-filter-branch but they're not used and unnecessary now. -Make the search case-insensitive: Just add .toLowerCase to the text input & the common/latin name checks. Probably wont need to do this for other filter categories since we will be mostly using predefined icons.

I've changed both now, thanks.

@joel-yap joel-yap merged commit 3eef30d into master Aug 27, 2023
@joel-yap joel-yap deleted the search-engine branch October 9, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants