Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref filter stipe eco car #31

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Conversation

joel-yap
Copy link
Collaborator

Adds filter functionality to the carousel bars for CapShape, Ecology and Stipe, should be able to click on the icons to add filters, click again to remove the filter.

@joel-yap joel-yap changed the base branch from master to refactored-filters September 24, 2023 02:50
Copy link
Collaborator

@AdamN2424 AdamN2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stipe type and Ecology filters seem to be working as intended, based on the logs. Need to sort our JSON data because no results are being displayed on these filters just yet.

I see you've added a 'stipe_features.type' field. We should keep all these values in lowercase so we don't have to use .tolower(). We can also remove the volva/ring field.
I'd also suggest changing the string passed on the stipe type carousel inputs. We don't need the word 'stipe' in there as that won't be a stipe type. so from: 'volvaringstipe' to 'volva ring'
having a space will also make the data easier to follow (for admins)

Could you make these small changes before this is merged?

@AdamN2424
Copy link
Collaborator

Thanks Joel.
Merging now then I'll merge the final carousel and get it all on master.

@AdamN2424 AdamN2424 merged commit 0d57ee4 into refactored-filters Sep 25, 2023
@joel-yap joel-yap deleted the ref-filter-stipe-eco-car branch October 9, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants