Seasonfilter #44
Merged
Seasonfilter #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joel-yap
requested review from
AdamN2424,
RosieHall,
EmilyClare4 and
kloudsoft91
AdamN2424
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Looks good, works as intended. I still think a specific month will be better than season because a lot of the data will specify a range within months, not seasons, like "Late Spring to Autumn (October to April - southern hemisphere). So going by month will filter more accurately.
kloudsoft91
had a problem deploying
to
github-pages
GitHub Actions
Failure
kloudsoft91
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch should add functional colour and season carousels, colour is currently a textbox but the functionality could be connected to emitter colour buttons later.