Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Season month #50

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Season month #50

merged 2 commits into from
Oct 12, 2023

Conversation

joel-yap
Copy link
Collaborator

Changed the month carousel filter to be a dropdown list of options, finds mushrooms with a month range that includes the selected month

AdamN2424
AdamN2424 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@AdamN2424 AdamN2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as intended. I think we should alter the currentMonth()/monthToInt() methods in FilterBar.vue and Index.vue because it's a bit verbose. Could just use an array of months.

@AdamN2424 AdamN2424 merged commit 96400f1 into master Oct 12, 2023
3 of 4 checks passed
@kloudsoft91 kloudsoft91 deleted the season-month branch October 21, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamN2424 AdamN2424 AdamN2424 approved these changes

@RosieHall RosieHall Awaiting requested review from RosieHall

@EmilyClare4 EmilyClare4 Awaiting requested review from EmilyClare4

@kloudsoft91 kloudsoft91 Awaiting requested review from kloudsoft91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joel-yap @AdamN2424