Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress testing #65

Merged
merged 18 commits into from
Oct 23, 2023
Merged

Cypress testing #65

merged 18 commits into from
Oct 23, 2023

Conversation

EmilyClare4
Copy link
Collaborator

Cypress End-to-End testing

@EmilyClare4 EmilyClare4 self-assigned this Oct 20, 2023
@EmilyClare4 EmilyClare4 marked this pull request as draft October 20, 2023 11:33
@EmilyClare4 EmilyClare4 marked this pull request as ready for review October 21, 2023 08:09
@EmilyClare4 EmilyClare4 marked this pull request as draft October 21, 2023 08:11
@EmilyClare4 EmilyClare4 marked this pull request as ready for review October 22, 2023 11:40
@EmilyClare4 EmilyClare4 marked this pull request as draft October 22, 2023 11:40
kloudsoft91
kloudsoft91 previously approved these changes Oct 22, 2023
Copy link
Owner

@kloudsoft91 kloudsoft91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, conditionally approved (see comments on files). Will merge after conversations are resolved

@kloudsoft91
Copy link
Owner

Apologies, one more thing, if there is a local cli command to do the e2e testing, please add necessary steps and information to the readme. e.g. change the url to visit in spec.cy.ts and then run command abc etc.

@kloudsoft91 kloudsoft91 merged commit 7daebdd into master Oct 23, 2023
3 of 4 checks passed
@kloudsoft91 kloudsoft91 deleted the cypress-testing branch October 23, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants