Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late validation for multiple apply calls #155

Closed
pauxus opened this issue Feb 27, 2019 · 1 comment · Fixed by #277
Closed

Late validation for multiple apply calls #155

pauxus opened this issue Feb 27, 2019 · 1 comment · Fixed by #277

Comments

@pauxus
Copy link
Member

pauxus commented Feb 27, 2019

Related to #120. Currently, when calling apply inside an apply script, validation is still called.

This is a problem when we split a configuration into multiple files, because createFrom calls apply. The state of validation (inner or outer object) should be somehow persisten inside a ThreadLocal.

@pauxus pauxus mentioned this issue Feb 27, 2019
@pauxus
Copy link
Member Author

pauxus commented Mar 18, 2019

Note: in that case, need to prevent cycles ($validated field?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant