Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hook and suggested Cython configuration. #2

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Add pre-commit hook and suggested Cython configuration. #2

merged 2 commits into from
Feb 16, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 15, 2022 •
edited
Loading

This PR adds suggested configurations for flake8 and pre-commit that play nicely with this plugin. @kmaehashi Happy to hear your thoughts!

kmaehashi
kmaehashi reviewed Feb 16, 2022
View reviewed changes
Copy link
Owner

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdice, looks great!

README.md Show resolved Hide resolved
bdice
bdice commented Feb 16, 2022
View reviewed changes
README.md Show resolved Hide resolved
@bdice bdice requested a review from kmaehashi February 16, 2022 00:48
kmaehashi
kmaehashi approved these changes Feb 16, 2022
View reviewed changes
Copy link
Owner

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! 👍🏼

@kmaehashi kmaehashi merged commit 0f5d30d into kmaehashi:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaehashi kmaehashi kmaehashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @kmaehashi