Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer 'require' function instead of deprecated 'module'. fix #23 #28

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

aw-engineer
Copy link
Contributor

@aw-engineer aw-engineer commented Jul 8, 2024

Summary

Refactor code to define packages with the pattern

local M = {}
M.method = ...
return M

to be loaded by the pattern

local complex = require("complex.lua")

How to test

test cases are defined by:

  • tests/*.lua, and
  • examples/*.lua

additional dependencies

procedure

With the run_tests.sh from #25:

./tests/run_tests.sh -i "lua5.1 lua5.2 lua5.3 lua5.4" --coverage --noclean

observe no errors

With the run_examples.sh from #29:

./examples/run_examples.sh -i "lua5.1 lua5.2 lua5.3 lua5.4" --coverage

observe no errors

@aw-engineer
Copy link
Contributor Author

test results from my integration branch here: https://github.com/aw-engineer/rFSM/actions/runs/9832970143

@aw-engineer
Copy link
Contributor Author

@kmarkus kmarkus merged commit 0f9239f into kmarkus:master Jul 8, 2024
@kmarkus
Copy link
Owner

kmarkus commented Jul 8, 2024

great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants