add proposal of Kmesh observability #337
Conversation
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
/hold |
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
docs/proposal/observability.md
Outdated
|
|
||
| As shown in the follow figure, Kmesh's Ads controller passes the access log filter to the Accesslog Controller to parse out the access log format. | ||
|
|
||
| Then according to the configuration, monitor the workload, collect the metrics to generate access log, and store the generated access log locally or send it to istiod. |
There was a problem hiding this comment.
may be you miss some details here, how can theser metrics recorded. How can we correlate a metric with a connection/req, i am asking becuase accesslog is one per request for http. and one per connection for tcp
|
cc @zirain |
docs/proposal/observability.md
Outdated
|
|
||
| The telemetry controller combines the metrics into an access log based on the access log format, and puts it in the envoyfilter to return to the control plane. | ||
|
|
||
| For metric features, provide 15001 port for Prometheus queries. |
There was a problem hiding this comment.
| For metric features, provide 15001 port for Prometheus queries. | |
| For metric features, provide 15020 port for Prometheus queries. |
There was a problem hiding this comment.
BTY, it should be configurable and support prometheus annotations.
docs/proposal/observability.md
Outdated
|
|
||
| The xDS controller fetches the access log format and metric configurations from it. Then get the corresponding metrics from the workloads. | ||
|
|
||
| The telemetry controller combines the metrics into an access log based on the access log format, and puts it in the envoyfilter to return to the control plane. |
|
Another brainstorming: consider support OpenTelemetry with push mode? |
LiZhenCheng9527
force-pushed
the
accesslog-proposal
branch
from
1f52441
to
20866eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Flags with carried forward coverage won't be shown. Click here to find out more. |
| connection_opens: The total number of TCP connections opened | ||
| connection_close: The total number of TCP connections closed | ||
| received_bytes: The size of total bytes received during request in case of a TCP connection | ||
| sent_bytes: The size of total bytes sent during response in case of a TCP connection | ||
| on_demand_dns: The total number of requests that used on-demand DNS (unstable) | ||
| on_demand_dns_cache_misses: The total number of cache misses for requests on-demand DNS (unstable) |
There was a problem hiding this comment.
some metrics like sent_bytes should have some labels, please double check what does it look like, and socument it here
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
accesslog-proposal
branch
from
fa233db
to
4a4f5bf
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
a part of #320
Special notes for your reviewer:
Does this PR introduce a user-facing change?: