SBK 2.0 Pre1 #404

kmgowda · 2022-10-03T14:22:23Z

Signed-off-by: Keshava Munegowda keshava.gowda@gmail.com

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

use long variables Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add Read and Write Requests benchmarking Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

logger. Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Implement SBP: Storage Benchmark Protocol

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Implement CQueue using VarHandles Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Update the read requests and write requests using var handles Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Implement MapLatencyRecorder Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add primitive long integer based Hashmap implementation. Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

sonatype-lift · 2022-10-03T14:42:00Z

sbm/src/main/java/io/sbm/api/impl/SbmBenchmark.java

@@ -177,7 +172,7 @@ private void shutdown() {
            } catch (IOException e) {
                e.printStackTrace();


CatchAndPrintStackTrace: Logging or rethrowing exceptions should usually be preferred to catching and calling printStackTrace

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T14:42:02Z

sbm/src/main/java/io/sbm/api/impl/SbmBenchmark.java

@@ -153,7 +148,7 @@ public CompletableFuture<Void> start() throws IOException, InterruptedException,
            return retFuture.toCompletableFuture();
        }
        state = State.RUN;
-        Printer.log.info("SBK RAM Benchmark Started");
+        Printer.log.info("SBM Started");
        logger.open(params, params.getStorageName(), params.getAction(), time);
        benchmark.start();


FutureReturnValueIgnored: Return value of methods returning Future must be checked. Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T14:42:03Z

sbm/src/main/java/io/sbm/api/impl/SbmBenchmark.java

@@ -153,7 +148,7 @@ public CompletableFuture<Void> start() throws IOException, InterruptedException,
            return retFuture.toCompletableFuture();
        }
        state = State.RUN;


GuardedBy: This access should be guarded by 'this'; instead found: 'this.$lock'

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T14:42:04Z

sbm/src/main/java/io/sbm/api/impl/SbmBenchmark.java

-    private @NotNull RamPeriodicRecorder createLatencyRecorder() {
-        final LatencyRecordWindow window = PerlBuilder.buildLatencyRecordWindow(ramConfig, time,
+    private @NotNull SbmPeriodicRecorder createLatencyRecorder() {
+        final LatencyRecordWindow window = PerlBuilder.buildLatencyRecordWindow(sbmConfig, time,
                logger.getMinLatency(), logger.getMaxLatency(), percentileFractions);
        final LatencyRecordWindow totalWindow;
        final LatencyRecordWindow totalWindowExtension;
        final Random random = new Random();


PREDICTABLE_RANDOM: This random generator (java.util.Random) is predictable

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T14:42:09Z

⚠️ 3 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

kmgowda added 30 commits August 5, 2022 19:45

set the SBK version to 2.0-pre

92c1499

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add new interfaces WriteRequestsLogger and ReadRequestsLogger

463c2a2

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

add requestWrites and requestReads APIs

b19b831

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

implement WriteRequests

71e9f8c

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add Read Requests to reader interfaces

5b8479c

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add the writer and reader requests benchmarking

aa6032d

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Implement minimum latency

6872d0a

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Update the minimum latency in LatencyWindow

c9f8042

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Change the signatures of recordWritRequests and recordReadRequests to

4fad027

use long variables Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Change the proto file to include read and write requests

30429db

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Code cleanup

817def7

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

code cleanup

5d8ad1e

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add write requests and read requests for the GRPC logger

f9ea2a6

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Code cleanup

7fe23bc

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

incrase the array size for the write and read requests for RAM logger

c70e49a

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Implement RWPrint interface

cf45371

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Bug fix to print issues with GRPC enabled

ada5e96

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Code cleanup

a329b5c

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Change the signature of RWPrint

718b212

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add the write and read Requests metrics

69a1098

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add the printMetrics

3b7991b

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Merge pull request #377 from kmgowda/kmg-sbk-2.0-req-1

6124cc3

Add Read and Write Requests benchmarking Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add SBP : Storage Benchmark Protocol

9e03066

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

rename the package io.sbk -> io.sbp for SBP module

6e0d619

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

reformat the printing of results

c7e3b88

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Update the max writers and max readers calculation in RAM promethesus

96550ca

logger. Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Update the grpc version to 1.48.1

db0afcc

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Merge pull request #378 from kmgowda/kmg-sbk-2.0-sbp-1

e14830f

Implement SBP: Storage Benchmark Protocol

Rename the module "sbk-ram" -> "SBM" , SBM: Storage Benchmark Monitor.

c3794cd

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

rename the package io.sbk -> io.sbm

a3c451e

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

kmgowda added 24 commits September 7, 2022 11:46

CQueue implementation with VAR handles

3d9e3b2

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Implement concurrent queue using VarHandles

a18ba59

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Code cleanup

293467a

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Code cleanup

b259602

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Merge pull request #397 from kmgowda/kmg-sbk-2.0-cq-5

b798315

Implement CQueue using VarHandles Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Code cleanup

d7557ce

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Code cleanup

30ff0fc

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Set the verison to 2.0-pre1

8da6de6

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add the Atomic getandSet to Node of CQueue

c5ff4cd

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Merge pull request #398 from kmgowda/kmg-sbk-2.0-cq-6

9b8653c

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Code cleanup

25157be

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Replace getAndSet by getAndSetRelease fro VarHandles of CQueue

71bc81d

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Update the read requests and write requests using var handles

a139e6e

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Make read request and write request as long variables

9490987

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Merge pull request #399 from kmgowda/kmg-sbk-2.0-var-handle-1

756fbb2

Update the read requests and write requests using var handles Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add the OS independent path seperator to sbk-charts

4b7d606

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Implement MapLatencyRecorder

865a6a2

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Merge pull request #401 from kmgowda/kmg-sbk-2.0-map-1

f80c5a2

Implement MapLatencyRecorder Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add primitve long integer based Hashmap implementation.

47dcb43

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add relace key in map latency recorder

0eb43e1

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Add addtoValue in LongHashMap

a98c6e5

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Merge pull request #402 from kmgowda/kmg-sbk-2.0-longhashmap

982c259

Add primitive long integer based Hashmap implementation. Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Code cleanup

22415a6

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>

Merge branch 'master' into sbk-2.0

55ea93a

kmgowda merged commit 1b46eb4 into sbk-2.0-pre Oct 3, 2022

sonatype-lift bot reviewed Oct 3, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SBK 2.0 Pre1 #404

SBK 2.0 Pre1 #404

kmgowda commented Oct 3, 2022

sonatype-lift bot Oct 3, 2022

sonatype-lift bot Oct 3, 2022

sonatype-lift bot Oct 3, 2022

sonatype-lift bot Oct 3, 2022

sonatype-lift bot commented Oct 3, 2022

		@@ -177,7 +172,7 @@ private void shutdown() {
		} catch (IOException e) {
		e.printStackTrace();

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

SBK 2.0 Pre1 #404

SBK 2.0 Pre1 #404

Conversation

kmgowda commented Oct 3, 2022

sonatype-lift bot Oct 3, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 3, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 3, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 3, 2022

Choose a reason for hiding this comment

sonatype-lift bot commented Oct 3, 2022