Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win64 Problem #4

Closed
rothe opened this issue Aug 5, 2013 · 9 comments
Closed

Win64 Problem #4

rothe opened this issue Aug 5, 2013 · 9 comments

Comments

@rothe
Copy link

rothe commented Aug 5, 2013

The following Code is breaks under 64bit windows. 32bit Windows is ok, 64bit Linux does also work.

I've compiled the win-64bit extension with MSVC 2010.


marisa_trie.Trie([u'Das', u'Lahnth.al', u'mit', u'seinen', u'Heilquellen']).keys()

d:\vls-trunk\env-win64\Python27\lib\site-packages\marisa_trie.pyd in marisa_trie._Trie.keys (src\marisa_trie.cpp:4199)()

d:\vls-trunk\env-win64\Python27\lib\site-packages\marisa_trie.pyd in marisa_trie._Trie.keys (src\marisa_trie.cpp:4061)()

RuntimeError: Unknown exception

@kmike
Copy link
Member

kmike commented Aug 5, 2013

I've tried marisa-trie on Windows in past and it worked, but I don't recall what MSVC version it was and was it 32 or 64 bit. It is hard to find a Windows machine to dig deeper. Could you please try a couple of things to help localize the issue?

  1. Are other methods working?
  2. Are console utils from here: https://code.google.com/p/marisa-trie/ working?
  3. If Trie.save works, does marisa-predictive-search console program work with saved Trie?

If some of console utils doesn't work then the issue is in marisa C++ library and it is better to report the problem upstream here: https://code.google.com/p/marisa-trie/issues/list . If they work, the issue is with a wrapper, but currently I have no idea what may cause it.

@rothe
Copy link
Author

rothe commented Aug 5, 2013

Yeah, i think now it's an issue in the marisa C++ library. I've build the marisa 0.2.4 library for 64bit windows and the tests are failing with similar errors.

I'm gonna report it there. Thnx, for your help

@rothe
Copy link
Author

rothe commented Aug 5, 2013

@kmike
Copy link
Member

kmike commented Aug 5, 2013

Thanks!

@superbobry
Copy link
Member

The 64bit issue is still there according to AppVeyor.

superbobry added a commit that referenced this issue Mar 13, 2016
@superbobry
Copy link
Member

The issue was fixed upstream (see s-yata/marisa-trie#2).

@vient
Copy link

vient commented Aug 5, 2016

So when the new version will be released, or how can we fix it ourselves?

@superbobry
Copy link
Member

Initially I wanted to sync our release with the C++ library, but now I think it might be easier to checkout the current s-yata/marisa-trie master into this repo and not wait for the official release.

You should be able to do this locally.

@vient
Copy link

vient commented Aug 9, 2016

Just confirmation that deleting this line

solves the problem.

superbobry added a commit that referenced this issue Sep 2, 2016
  so it now includes a patch for #4!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants