Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosolve does not always work #16

Open
daganzdaanda opened this issue Mar 16, 2022 · 72 comments
Open

Autosolve does not always work #16

daganzdaanda opened this issue Mar 16, 2022 · 72 comments
Assignees

Comments

@daganzdaanda
Copy link

Look at https://www.openstreetmap.org/changeset/118560111 and see that the linked notes are still open.
Sadly, I did not run with the --debug flag.
What I recall doing:
I downloaded a lot of notes with josm to look for things I could work on. I have set JOSM to also download closed notes for 500 days, and a limit of 1000 notes downloaded at once. I may have had more than 1000 notes downloaded.
I looked at a few open notes and saw https://www.openstreetmap.org/note/2442094 which I commented on and set to "remember". Then I worked on https://www.openstreetmap.org/note/2980584 and https://www.openstreetmap.org/note/2695620, also adding a comment and setting them to "remember".
This one https://www.openstreetmap.org/note/3087172 I clicked on "remember" but then decided it should remain open and clicked "forget". I also added a comment there.

I'm not 100% sure whether I first added the comments and afterwards pressed "remember" or if it may have been the other way round, too. But I did similar stuff when I tried to replicate #11 and I never got a problem then...

I also can't say if the comments were uploaded by NoteSolver or if it happened afterwards as I pressed JOSM's "upload changed notes" button.

Here's the JOSM status report after I saw that the notes were not closed.

@daganzdaanda
Copy link
Author

Some wild guesses for a possible reason:

  • Could there be a problem with just too many notes, since I dl'd a big area full of them?
  • Or does "forget note" sometimes clash with comments added through JOSM?

What's clear compared to my previous issue #11: This has nothing to do with interrupting the upload. This time I got a warning about "fixme" tagged things, but I continued the upload.

@daganzdaanda
Copy link
Author

Here's the --debug output with a test that did go wrong somehow, I think... but I'm getting confused right now, too many variables... 😕 😖

@daganzdaanda
Copy link
Author

It happened again: https://www.openstreetmap.org/changeset/118756500 should have closed three issues. No --debug info, sorry.

This time there were not a lot of notes dl'd, so probably not a memory problem.
I also did not click "forget note".
I added a comment to two of the notes and after that marked them as "remember".
I continued mapping and when I wanted to upload everything, the autosolve dialogue came up where I chose yes. Then the validator had some warnings so I cancelled the upload to fix these.
Again, upload - autosolve - yes - another validator warning - cancel.
So again, fix warnings - upload - autosolve - yes - and now at the third try there were no warnings that I could fix anymore.
I continued to add a few words to the changeset comment and finished the upload. I did not get the message that the notes were being closed / uploaded, but also no error message.

The two comments I added to the notes have been uploaded, but I think I did that "manually" through JOSM (should be visible from the timestamp being different than the changeset timestamp?)

@daganzdaanda
Copy link
Author

Wild guess number 3: Could adding something to the changeset comment lead to some issue here?

@daganzdaanda
Copy link
Author

daganzdaanda commented Mar 22, 2022

This time there was only one note to remember, and it did not get closed:
https://www.openstreetmap.org/changeset/118797668
https://www.openstreetmap.org/note/2078000
Hopefully this gist of JOSM --debug output is helpful for you.

What I did this time:
add comment to note > set to remember
keep working
try upload > autocomplete dialog > yes > validator issues > cancel
repeat until satisfied
then add a few words to prefilled changeset comment > upload to server.
Result: changeset is uploaded, but the note is ignored - the comment is not uploaded, and the note remains open.

@daganzdaanda
Copy link
Author

Again I tried unsuccessfully to reproduce the problem with a new JOSM home directory on master.apis.dev.openstreetmap.org
Just adding a few words or characters to the changeset comment is not what makes the plugin forget to close the notes.
I have no idea how to get closer to the problem..... 😢 It seems complicated, maybe there's some interference with other plugins?

@daganzdaanda
Copy link
Author

@daganzdaanda
Copy link
Author

This time I noticed that when I wanted to exit, I got the info from JOSM that there are changed notes that have not been uploaded. So I cancelled the exit to get a status report and the debug output. Then I clicked the upload notes button and afterwards I was able to exit without a reminder from JOSM. The comments that I added to the notes were uploaded, but the notes are still open (Makes sense, JOSM does not know I wanted to close them.)

@daganzdaanda
Copy link
Author

And again: Changeset; Josm status; Josm debug
This time I interrupted the upload to fix the validator's warnings again, and with the second try added text to the changeset comment and the changeset sources field.

Any idea what's keeping the notes from being closed automatically?

@daganzdaanda
Copy link
Author

daganzdaanda commented Apr 4, 2022

Another one:
Changeset; Josm status; Josm debug
This time I did not interrupt the upload.

@daganzdaanda
Copy link
Author

@kmpoppe Do you see any plugin I'm using that might be interfering with noteSolver?

@kmpoppe
Copy link
Owner

kmpoppe commented Apr 5, 2022

Hey @daganzdaanda,

so one problem I'm guessing is that you make changes to the notes without uploading those first before you upload the changeset. That's something I have never tested as to how it might change the state of the note or even prevents closure.
I will give that some thought. Maybe there are ways to detect non uploaded changes and start a "sync" on them first.

The problem with the upload being cancelled due to QA checks by JOSM was something I could never replicate creating weird results.

The exclude any other plugins interfering, could you please find yourself an area and a note, where no QA will interfere (you can check them before you hit the changeset upload) and where you do not add any comments to the note, and then do a simple change, remember the note for closure and upload it? If that gets closed properly on both ends we'd be one step further.

K

@daganzdaanda
Copy link
Author

I just did this changeset, only one note remembered, no comment added to the note, only one change, no validation problems, no editing the changeset fields. Having all the same plugins as before installed.
It worked as it should.
I remember that I had some successful auto-closures earlier also with adding a comment to the notes before. So I'll try this again now.

@daganzdaanda
Copy link
Author

Yeah, it is possible to add a comment to notes and have them still autoclosed: Changeset

@daganzdaanda
Copy link
Author

After you told me in #11 how to do it, I did a whole round of tests on the master dev-server with a clean JOSM: https://master.apis.dev.openstreetmap.org/user/dgda2/history#map=14/80.0695/12.4836
I was even provoking validator issues there, and tried to systematically vary what I did to the notes in what sequence, trying to reproduce the issue but it never showed up...

And before that, I tried in a series of changesets on the normal server with my normal JOSM and plugins, see https://www.openstreetmap.org/changeset/118487490
https://www.openstreetmap.org/changeset/118487490
https://www.openstreetmap.org/changeset/118487620
https://www.openstreetmap.org/changeset/118487724
https://www.openstreetmap.org/changeset/118487885
https://www.openstreetmap.org/changeset/118488008
https://www.openstreetmap.org/changeset/118488517
https://www.openstreetmap.org/changeset/118488909
and the linked notes.
Again, I was not able to get the problem in those "laboratory" conditions.

@daganzdaanda
Copy link
Author

https://master.apis.dev.openstreetmap.org/changeset/234137#map=16/80.0685/12.5079&layers=ND
The note https://master.apis.dev.openstreetmap.org/note/30268 was not closed.
I had been adding plugins one by one, and merging nodes with "M" to check if I could get at #18
I did not upload unless the new plugin needed a restart of JOSM.
The last plugin I installed was "public transport", before that in the same session (from latest to earliest) "pt assistant", "photo geotagging", "open qa", "opendata".
Josm status
Josm debug

@daganzdaanda
Copy link
Author

image
The note is still set to "remember".

@daganzdaanda
Copy link
Author

Still same JOSM session, no restart:
After making another change I tried uploading again. I got the "close note automatically" again, and the validator errors again, but this time with the upload it actually did get closed.
https://master.apis.dev.openstreetmap.org/changeset/234141

@daganzdaanda
Copy link
Author

restarted JOSM continued installing plugins.
Screenshot 2022-04-07 011144
Screenshot 2022-04-07 011210
Screenshot 2022-04-07 011237
https://master.apis.dev.openstreetmap.org/changeset/234146#map=16/80.0685/12.5079&layers=ND
https://master.apis.dev.openstreetmap.org/note/30259 still open
JOSM debug
JOSM status

newest plugin was "tageditor"
before came "scripting", "reverter", "reltoolbox".
Using "M" to merge nodes was no problem in all of these tests.

@daganzdaanda
Copy link
Author

closing JOSM right after this gives the "unsaved notes" reminder. I selected to "upload changes before closing".
very interesting result in https://master.apis.dev.openstreetmap.org/note/30259
image
so the last two comments about new plugins were not uploaded!

@daganzdaanda
Copy link
Author

daganzdaanda commented Apr 6, 2022

next changeset without adding any more plugins, only one merged node, added 2 comments to note, no validation popup: note was solved and closed.

same session, added terracer and turnlanes plugins - needs restart, did not allow to close JOSM just right away. Tried some another merge operation, no problem. Then did the upload, this time with a validator warning (ignored), upload went fine, note is closed: https://master.apis.dev.openstreetmap.org/changeset/234162#map=16/80.0686/12.5078&layers=ND

@daganzdaanda
Copy link
Author

changeset
did not close https://master.apis.dev.openstreetmap.org/note/30274
josm debug
josm status
note looks like this in josm:
Screenshot 2022-04-07 014848
first a comment was added, then set to remember, then the other comments.
all comments were added before doing the upload.
no new plugins were added.
"m" merging was not a problem.

@daganzdaanda
Copy link
Author

closed JOSM
Screenshot 2022-04-07 015820
let it upload the changed notes, result:
image

1 comment uploaded, 4 comments forgotten.
Very weird.

@daganzdaanda
Copy link
Author

I had an issue with notes not uploading when exiting more than a year ago already, see JOSM ticket 20566. I didn't know of noteSolver at that time. So it this specific problem is likely no fault of noteSolver. But it may make finding the other issue(s?) more difficult.

@daganzdaanda
Copy link
Author

daganzdaanda commented May 28, 2022

debug
status

Hi again... haven't been mapping a lot lately, but now this issue has shown up again. Only two notes, I did add a comment to both and uploaded the comments first. Only after that I used the "remember note" function. When I uploaded the changeset I did see the notice that the notes will be closed, and the info was in the changeset comment field. The changeset made it to the server: https://www.openstreetmap.org/changeset/121627394 but the notes are still open as I type: https://www.openstreetmap.org/note/3192635 and https://www.openstreetmap.org/note/3192633
ETA: in JOSM notesolver still shows "forget note" selectable on these notes, so it seems to know that they haven't uploaded.

Maybe you can find a pattern in all of the debug info I've collected?
Even if it might have a JOSM bug as its root?

I really like this plugin, it's just a shame that it does not seem to work reliably on my computer...

kmpoppe added a commit that referenced this issue Jun 13, 2022
Changed behaviour of Note Upload to check for more events and their order so that a more consistent behaviour should be reached.

This aims to address #16 and #18 and requires some testing.
@kmpoppe
Copy link
Owner

kmpoppe commented Jun 13, 2022

Hi @daganzdaanda,
I published a beta (https://github.com/kmpoppe/noteSolver/releases/download/0.4.3-beta1/notesolver.jar) that I think addresses this and #18. Could you test this please?
K

@risturiz
Copy link

Tested :-) ... Maybe my issue have relation with this... The plugin don't close the note when i create a lot of nodes ( highways ), but works when i edit few nodes.

@daganzdaanda
Copy link
Author

Hi @kmpoppe

Thanks! I installed the beta version but didn't do any mapping for a while...
Now I did use it on one note, with no good result 😢 changeset says it's closing the note, but the note is still open.
https://www.openstreetmap.org/note/3171536
https://www.openstreetmap.org/changeset/123493273
status
debug
Hope you can find something in those logs...

Screenshot 2022-07-12 001927

You can see that I added a comment to that note. I thought I pressed the green arrow to upload the comment before I uploaded the changeset, but I seem to have mis-clicked: the arrow is still green and the comment is not yet visible on the website.
I now pressed the green button again, and the comment got uploaded, and then I closed the note manually.

@kmpoppe
Copy link
Owner

kmpoppe commented Apr 14, 2023

So ... are you always trying to add additional comments to a note before you try to close them via noteSolver? I can only imagine that the Plugin simply cannot detect whether the note needs a change and thus won't upload anything.

@daganzdaanda
Copy link
Author

I just reproduced it: closed JOSM and restarted to new session. DL the area and notes.
Click on "close note" button, add text.
Click on "upload note changes to server" button. Nothing happens.
Click a second time on that button: Note change is uploaded (commented and closed)
status
debug

@daganzdaanda
Copy link
Author

Another test with a note around null island
debug
I needed 2 clicks again, but I can't interpret the debug output if it recorded the clicks or not.

@daganzdaanda
Copy link
Author

I removed a lot of plugins and tried again with another note.
This time everything worked with a single click!
status
debug

@daganzdaanda
Copy link
Author

I added back the notesolver plugin.
And now I had to double click the button again(!)
status
debug

The debug output also shows repeated lines again, was not looking like that last time, when I only needed one click to upload the changes.

kmpoppe added a commit that referenced this issue Apr 18, 2023
Removed unused imports and return variables.
Refactoring to hopefully have notes not upload early AND not not upload at all by removing Events that don't fire when expected.
References #16.
@kmpoppe
Copy link
Owner

kmpoppe commented Apr 18, 2023

It would seem I found the problem. @daganzdaanda @ygra @rohieb @risturiz please download the Pre-Release 0.5.2 to your local plugins-folder (Windows: %APPDATA%\JOSM\plugins).

Please lemme know if this finally solved the problem :)

@kmpoppe kmpoppe self-assigned this Apr 21, 2023
@mcliquid
Copy link

@kmpoppe I'm using v0.5.3 after your fix in #27 and still have this error.
https://www.openstreetmap.org/changeset/135260587
2023-04-23 14_53_40-Java-OpenStreetMap-Editor

@daganzdaanda
Copy link
Author

daganzdaanda commented Apr 24, 2023

Really sorry...
https://www.openstreetmap.org/note/3482523 is still open, https://www.openstreetmap.org/changeset/135308770 should have closed it.
No extra comment was added this time.
debug
status
plugin version is 0.5.2 for this changeset

@daganzdaanda
Copy link
Author

Now with plugin v0.5.3 and updated Java... same result.

https://www.openstreetmap.org/note/3481809
changeset
status
debug

@daganzdaanda
Copy link
Author

I continued in the same JOSM session without manually uploading / closing the notes. Found another note to fix and remember, also added 2 comments there. Then did the upload procedure again. This time I was asked if I wanted to close the 2 notes. And it worked!

https://www.openstreetmap.org/note/3481810
https://www.openstreetmap.org/note/3481809

debug

Of course the link on https://www.openstreetmap.org/note/3481809 is wrong, it was fixed with the previous changeset.

🤷

@daganzdaanda
Copy link
Author

So ... are you always trying to add additional comments to a note before you try to close them via noteSolver?

Often, but not always, see above
I think adding additional info in a comment is very often helpful and polite. But it seems not to be the reason of the problem.

@daganzdaanda
Copy link
Author

https://www.openstreetmap.org/note/3013252
This worked.
Was a new session, only this note, no comment added to the note, also none on the changeset.

@daganzdaanda
Copy link
Author

Then went on to another note in the same session

https://www.openstreetmap.org/note/3013253
marked to remember
added a comment
uploaded
https://www.openstreetmap.org/changeset/135315604

did not work
debug

You can see that the note was visible and "open" (you asked about that earlier).
Screenshot 2023-04-24 211156

@daganzdaanda
Copy link
Author

I wanted to see if the note would be uploaded with the next changeset. So I started finetuning some houses. I used some shortcuts, probably x for extrude and s for select, and maybe ctrl-z for undo. Suddenly the info "updating changed notes" (or similar) flashed up and disappeared again quickly. And the note has been uploaded. I haven't had to make another changeset this time.

debug

BUT https://www.openstreetmap.org/note/3013253 says

Resolved with changeset https://www.openstreetmap.org/changeset/32785387

That changeset is 8 years old.
The way that I was just working on when the sudden note upload happened was
https://www.openstreetmap.org/way/90051621
which was last changed in that old changeset.

This seems like a recurrence of #18

@natrius
Copy link

natrius commented Jun 18, 2023

It seems i had the same problem now.
I edited, remembered some notes, uploaded. I got the windows "Autoresolve notes" and then got the cs-comment added and uploaded. Nothing happened to the notes. Then i changed a small detail i missed before and uploaded again, i got asked again to resolve the same notes as before and after uploading i got the notification "Note was already closed outside" or something like that.

@rohieb
Copy link

rohieb commented Jun 21, 2023

What's strange to me (still on 0.5.0, sorry, I haven't figured out how to build the plugin myself):

  • On the first auto-solve question, I say "yes" to auto-close a remembered note. However, the note is not closed after uploading the changes.
  • But, if I then un-remember the non-closed note (via the context menu on the note, or even in the main menu bar via "Forget all notes" or something), I still get the auto-solve question when I try to upload changes again.
  • Even when I say "No" on the auto-upload question, the changeset comment is pre-formatted with "Closes http://…[note-URL]" and I get the "closed:note=[number]" in the changeset tags, which I then have to delete again.

@daganzdaanda
Copy link
Author

Again...
This time again with 0.53 beta (I always forget to replace the noteSolver.jar after an JOSM update)
https://www.openstreetmap.org/changeset/139611741
No comments added this time. Notes are still open. I think none of the three notes was in view when I uploaded.

debug info
status info

@daganzdaanda
Copy link
Author

Aha, managed to reproduce the behaviour above.

Continuing the JOSM session, played around with an existing building.
Clicked on it, x for extrude, s for select, del for delete, ctrl-z for undo
Then suddenly the still left over changed notes were uploaded and closed.
https://www.openstreetmap.org/note/3258123
The inserted comment says " Closed with https://www.openstreetmap.org/changeset/71960122 ", which again is an old changeset that happens to be the last to change the building I was playing around with.

debug output

@mcliquid
Copy link

mcliquid commented Oct 5, 2023

Today I had a crash due to the noteSolver.
Attached also the StackTrace. JOSM version 18854 and noteSolver 0.5.0

STACK TRACE

{{{
Thread: AWT-EventQueue-1 (53) of JOSM (development version)
java.lang.reflect.InvocationTargetException
at java.desktop/java.awt.EventQueue.invokeAndWait(EventQueue.java:1369)
at java.desktop/java.awt.EventQueue.invokeAndWait(EventQueue.java:1344)
at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:99)
at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:142)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.ClassCastException: class org.openstreetmap.josm.gui.MainFrame cannot be cast to class javax.swing.JComponent (org.openstreetmap.josm.gui.MainFrame is in unnamed module of loader net.sourceforge.jnlp.runtime.classloader.JNLPClassLoader @1175b51d; javax.swing.JComponent is in module java.desktop of loader 'bootstrap')
at org.openstreetmap.josm.plugins.notesolver.NoteSolverPlugin$7.selectedNoteChanged(NoteSolverPlugin.java:201)
at org.openstreetmap.josm.data.osm.NoteData.lambda$setSelectedNote$0(NoteData.java:112)
at org.openstreetmap.josm.tools.ListenerList.fireEvent(ListenerList.java:155)
at org.openstreetmap.josm.data.osm.NoteData.setSelectedNote(NoteData.java:112)
at org.openstreetmap.josm.gui.dialogs.NotesDialog.lambda$buildDialog$0(NotesDialog.java:117)
at java.desktop/javax.swing.JList.fireSelectionValueChanged(JList.java:1831)
at java.desktop/javax.swing.JList$ListSelectionHandler.valueChanged(JList.java:1845)
at java.desktop/javax.swing.DefaultListSelectionModel.fireValueChanged(DefaultListSelectionModel.java:224)
at java.desktop/javax.swing.DefaultListSelectionModel.fireValueChanged(DefaultListSelectionModel.java:204)
at java.desktop/javax.swing.DefaultListSelectionModel.fireValueChanged(DefaultListSelectionModel.java:251)
at java.desktop/javax.swing.DefaultListSelectionModel.changeSelection(DefaultListSelectionModel.java:448)
at java.desktop/javax.swing.DefaultListSelectionModel.changeSelection(DefaultListSelectionModel.java:458)
at java.desktop/javax.swing.DefaultListSelectionModel.setSelectionInterval(DefaultListSelectionModel.java:502)
at java.desktop/javax.swing.JList.setSelectedIndex(JList.java:2232)
at java.desktop/javax.swing.JList.setSelectedValue(JList.java:2389)
at org.openstreetmap.josm.gui.dialogs.NotesDialog.selectionChanged(NotesDialog.java:235)
at org.openstreetmap.josm.gui.dialogs.NotesDialog.setNotes(NotesDialog.java:223)
at org.openstreetmap.josm.gui.dialogs.NotesDialog.noteDataUpdated(NotesDialog.java:207)
at org.openstreetmap.josm.data.osm.NoteData.lambda$dataUpdated$1(NoteData.java:254)
at org.openstreetmap.josm.tools.ListenerList.fireEvent(ListenerList.java:155)
at org.openstreetmap.josm.data.osm.NoteData.dataUpdated(NoteData.java:254)
at org.openstreetmap.josm.data.osm.NoteData.addNotes(NoteData.java:167)
at org.openstreetmap.josm.data.osm.NoteData.mergeFrom(NoteData.java:141)
at org.openstreetmap.josm.gui.layer.NoteLayer.mergeFrom(NoteLayer.java:374)
at org.openstreetmap.josm.actions.downloadtasks.DownloadNotesTask$DownloadTask.finish(DownloadNotesTask.java:149)
at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:308)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:771)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:722)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:716)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:741)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:117)
at java.desktop/java.awt.WaitDispatchSupport$2.run(WaitDispatchSupport.java:191)
at java.desktop/java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:236)
at java.desktop/java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:234)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:318)
at java.desktop/java.awt.WaitDispatchSupport.enter(WaitDispatchSupport.java:234)
at java.desktop/java.awt.Dialog.show(Dialog.java:1080)
at java.desktop/java.awt.Component.show(Component.java:1728)
at java.desktop/java.awt.Component.setVisible(Component.java:1675)
at java.desktop/java.awt.Window.setVisible(Window.java:1036)
at java.desktop/java.awt.Dialog.setVisible(Dialog.java:1016)
at org.openstreetmap.josm.gui.progress.swing.PleaseWaitProgressMonitor.lambda$doBeginTask$3(PleaseWaitProgressMonitor.java:255)
at org.openstreetmap.josm.gui.progress.swing.PleaseWaitProgressMonitor.lambda$doInEDT$0(PleaseWaitProgressMonitor.java:113)
at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:771)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:722)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:716)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:741)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
}}}

@daganzdaanda
Copy link
Author

Hi @kmpoppe

could you please release the latest 0.53 version on the official JOSM channel?

I seem to have forgotten to change the plugin (again 🙄) after updating JOSM. Only after I prepared another report I noticed that it was 0.50 again... JOSM always overwrites the local plugin when updating.

@daganzdaanda
Copy link
Author

So, even with 0.5.3 beta, the autosolve did not work again.
Status
Debug
https://www.openstreetmap.org/changeset/145340151
https://www.openstreetmap.org/note/3933568
This time I added 2 comments to the note and uploaded those. Only after that I made notesolver "remember" the note. When uploading the changeset, it did make it into the changeset comment, but wasn't closed.

@daganzdaanda
Copy link
Author

Right after the above, in the same JOSM session, I added a new building and uploaded it.
https://www.openstreetmap.org/changeset/145340420
This made notesolver ask again if I wanted to close the note from above. And this time, it was actually closed, but of course it links to the second changeset which actually did not concern it.
Here's the gist for the debug output

@daganzdaanda
Copy link
Author

Have any of these reports and gists actually helped you narrow down a problem, @kmpoppe ?
If you're stuck, I won't continue with them and just hope it's something that might magically go away, maybe with some new hardware or JAVA flavour...
Or maybe I should try and make reports in the (rare) cases that everything did go well?

@daganzdaanda
Copy link
Author

Now I changed my Java installation from Java version: 17.0.7+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM to Java version: 21.0.1+12-LTS, Eclipse Adoptium, OpenJDK 64-Bit Server VM and the first try with notesolver was a success 😄 ...let's hope it continues!
https://www.openstreetmap.org/changeset/145388406
Status
Debug

@daganzdaanda
Copy link
Author

Well, it was nice while it lasted 🤣
https://www.openstreetmap.org/changeset/145388674
did not close the note it says it closed. Same session as right before. Also added a comment to the note and uploaded that before closing the changeset (but I did that in the previous successful attempt too, I believe)
debug output

@angoca
Copy link

angoca commented Jan 6, 2024

I have created a video with the most recent beta plugin, and it still have problems when solving notes after having mapped a long ways with several nodes.

https://youtu.be/gHBDLIApGBI

@RubenKelevra
Copy link

Can confirm this bug is also happening for me. Success chance seems rather low that it actually works. But it does sometimes. Without no clear pattern on why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants