-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autosolve does not always work #16
Comments
Some wild guesses for a possible reason:
What's clear compared to my previous issue #11: This has nothing to do with interrupting the upload. This time I got a warning about "fixme" tagged things, but I continued the upload. |
Here's the --debug output with a test that did go wrong somehow, I think... but I'm getting confused right now, too many variables... 😕 😖 |
It happened again: https://www.openstreetmap.org/changeset/118756500 should have closed three issues. No --debug info, sorry. This time there were not a lot of notes dl'd, so probably not a memory problem. The two comments I added to the notes have been uploaded, but I think I did that "manually" through JOSM (should be visible from the timestamp being different than the changeset timestamp?) |
Wild guess number 3: Could adding something to the changeset comment lead to some issue here? |
This time there was only one note to remember, and it did not get closed: What I did this time: |
Again I tried unsuccessfully to reproduce the problem with a new JOSM home directory on master.apis.dev.openstreetmap.org |
It happened again: https://www.openstreetmap.org/changeset/118931559 |
This time I noticed that when I wanted to exit, I got the info from JOSM that there are changed notes that have not been uploaded. So I cancelled the exit to get a status report and the debug output. Then I clicked the upload notes button and afterwards I was able to exit without a reminder from JOSM. The comments that I added to the notes were uploaded, but the notes are still open (Makes sense, JOSM does not know I wanted to close them.) |
And again: Changeset; Josm status; Josm debug Any idea what's keeping the notes from being closed automatically? |
Another one: |
@kmpoppe Do you see any plugin I'm using that might be interfering with noteSolver? |
Hey @daganzdaanda, so one problem I'm guessing is that you make changes to the notes without uploading those first before you upload the changeset. That's something I have never tested as to how it might change the state of the note or even prevents closure. The problem with the upload being cancelled due to QA checks by JOSM was something I could never replicate creating weird results. The exclude any other plugins interfering, could you please find yourself an area and a note, where no QA will interfere (you can check them before you hit the changeset upload) and where you do not add any comments to the note, and then do a simple change, remember the note for closure and upload it? If that gets closed properly on both ends we'd be one step further. K |
I just did this changeset, only one note remembered, no comment added to the note, only one change, no validation problems, no editing the changeset fields. Having all the same plugins as before installed. |
Yeah, it is possible to add a comment to notes and have them still autoclosed: Changeset |
After you told me in #11 how to do it, I did a whole round of tests on the master dev-server with a clean JOSM: https://master.apis.dev.openstreetmap.org/user/dgda2/history#map=14/80.0695/12.4836 And before that, I tried in a series of changesets on the normal server with my normal JOSM and plugins, see https://www.openstreetmap.org/changeset/118487490 |
https://master.apis.dev.openstreetmap.org/changeset/234137#map=16/80.0685/12.5079&layers=ND |
Still same JOSM session, no restart: |
restarted JOSM continued installing plugins. newest plugin was "tageditor" |
closing JOSM right after this gives the "unsaved notes" reminder. I selected to "upload changes before closing". |
next changeset without adding any more plugins, only one merged node, added 2 comments to note, no validation popup: note was solved and closed. same session, added terracer and turnlanes plugins - needs restart, did not allow to close JOSM just right away. Tried some another merge operation, no problem. Then did the upload, this time with a validator warning (ignored), upload went fine, note is closed: https://master.apis.dev.openstreetmap.org/changeset/234162#map=16/80.0686/12.5078&layers=ND |
changeset |
I had an issue with notes not uploading when exiting more than a year ago already, see JOSM ticket 20566. I didn't know of noteSolver at that time. So it this specific problem is likely no fault of noteSolver. But it may make finding the other issue(s?) more difficult. |
Hi again... haven't been mapping a lot lately, but now this issue has shown up again. Only two notes, I did add a comment to both and uploaded the comments first. Only after that I used the "remember note" function. When I uploaded the changeset I did see the notice that the notes will be closed, and the info was in the changeset comment field. The changeset made it to the server: https://www.openstreetmap.org/changeset/121627394 but the notes are still open as I type: https://www.openstreetmap.org/note/3192635 and https://www.openstreetmap.org/note/3192633 Maybe you can find a pattern in all of the debug info I've collected? I really like this plugin, it's just a shame that it does not seem to work reliably on my computer... |
Hi @daganzdaanda, |
Tested :-) ... Maybe my issue have relation with this... The plugin don't close the note when i create a lot of nodes ( highways ), but works when i edit few nodes. |
Hi @kmpoppe Thanks! I installed the beta version but didn't do any mapping for a while... You can see that I added a comment to that note. I thought I pressed the green arrow to upload the comment before I uploaded the changeset, but I seem to have mis-clicked: the arrow is still green and the comment is not yet visible on the website. |
So ... are you always trying to add additional comments to a note before you try to close them via noteSolver? I can only imagine that the Plugin simply cannot detect whether the note needs a change and thus won't upload anything. |
Another test with a note around null island |
Removed unused imports and return variables. Refactoring to hopefully have notes not upload early AND not not upload at all by removing Events that don't fire when expected. References #16.
It would seem I found the problem. @daganzdaanda @ygra @rohieb @risturiz please download the Pre-Release 0.5.2 to your local plugins-folder (Windows: %APPDATA%\JOSM\plugins). Please lemme know if this finally solved the problem :) |
@kmpoppe I'm using v0.5.3 after your fix in #27 and still have this error. |
Really sorry... |
Now with plugin v0.5.3 and updated Java... same result. https://www.openstreetmap.org/note/3481809 |
I continued in the same JOSM session without manually uploading / closing the notes. Found another note to fix and remember, also added 2 comments there. Then did the upload procedure again. This time I was asked if I wanted to close the 2 notes. And it worked! https://www.openstreetmap.org/note/3481810 Of course the link on https://www.openstreetmap.org/note/3481809 is wrong, it was fixed with the previous changeset. 🤷 |
Often, but not always, see above |
https://www.openstreetmap.org/note/3013252 |
Then went on to another note in the same session https://www.openstreetmap.org/note/3013253 did not work You can see that the note was visible and "open" (you asked about that earlier). |
I wanted to see if the note would be uploaded with the next changeset. So I started finetuning some houses. I used some shortcuts, probably x for extrude and s for select, and maybe ctrl-z for undo. Suddenly the info "updating changed notes" (or similar) flashed up and disappeared again quickly. And the note has been uploaded. I haven't had to make another changeset this time. BUT https://www.openstreetmap.org/note/3013253 says
That changeset is 8 years old. This seems like a recurrence of #18 |
It seems i had the same problem now. |
What's strange to me (still on 0.5.0, sorry, I haven't figured out how to build the plugin myself):
|
Again... |
Aha, managed to reproduce the behaviour above. Continuing the JOSM session, played around with an existing building. |
Today I had a crash due to the noteSolver. STACK TRACE{{{ |
Hi @kmpoppe could you please release the latest 0.53 version on the official JOSM channel? I seem to have forgotten to change the plugin (again 🙄) after updating JOSM. Only after I prepared another report I noticed that it was 0.50 again... JOSM always overwrites the local plugin when updating. |
So, even with 0.5.3 beta, the autosolve did not work again. |
Right after the above, in the same JOSM session, I added a new building and uploaded it. |
Have any of these reports and gists actually helped you narrow down a problem, @kmpoppe ? |
Now I changed my Java installation from |
Well, it was nice while it lasted 🤣 |
I have created a video with the most recent beta plugin, and it still have problems when solving notes after having mapped a long ways with several nodes. |
Can confirm this bug is also happening for me. Success chance seems rather low that it actually works. But it does sometimes. Without no clear pattern on why |
Look at https://www.openstreetmap.org/changeset/118560111 and see that the linked notes are still open.
Sadly, I did not run with the --debug flag.
What I recall doing:
I downloaded a lot of notes with josm to look for things I could work on. I have set JOSM to also download closed notes for 500 days, and a limit of 1000 notes downloaded at once. I may have had more than 1000 notes downloaded.
I looked at a few open notes and saw https://www.openstreetmap.org/note/2442094 which I commented on and set to "remember". Then I worked on https://www.openstreetmap.org/note/2980584 and https://www.openstreetmap.org/note/2695620, also adding a comment and setting them to "remember".
This one https://www.openstreetmap.org/note/3087172 I clicked on "remember" but then decided it should remain open and clicked "forget". I also added a comment there.
I'm not 100% sure whether I first added the comments and afterwards pressed "remember" or if it may have been the other way round, too. But I did similar stuff when I tried to replicate #11 and I never got a problem then...
I also can't say if the comments were uploaded by NoteSolver or if it happened afterwards as I pressed JOSM's "upload changed notes" button.
Here's the JOSM status report after I saw that the notes were not closed.
The text was updated successfully, but these errors were encountered: