Change: ローカルタイムラインを無効にしている時、/api/v1/timelines/publicタイムライン取得で「リモートユーザーのみ」指定も無効化
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmycode
changed the title
/api/v1/timelines/publicタイムライン取得で「リモートユーザーのみ」指定も無効化
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
リアルタイムフィードの「リモートのみ」タブを削除し、リモート＆ローカル全部あわせたタイムラインしか表示できないように
ローカルのことを意識してしまうため必要
ただしAPIとして
remote=1を指定した場合、「連合タイムライン」を「リモートのみ」有効にして表示してしまうクライアントアプリがあるかもしれないので、空の配列ではなくremote=1を無視してローカル投稿も含む配列を返す（そういうのはクライアントアプリが悪いのだが、混合されうる場合があると思った）