Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: #647 NGワードの入力フォーム #663

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

kmycode
Copy link
Owner

@kmycode kmycode commented Mar 21, 2024

  • 内部処理
  • テストコード
  • 編集画面の改造
  • 編集画面の文言修正
  • 正規表現の正確さチェックをコントローラ内のチェックからバリデーションチェックに変更

部分的対応

  • Admin::NgWordのリファクタリング
    • センシティブワードのように、NGワードチェックメソッド呼び出し時にstranger: trueをオプションで付ける形にする
  • テストコードのリファクタリング
    • create_spec.rbなどの投稿・編集処理のテストでの確認事項を最小限にし、詳しい動作確認はadmin/ng_words_specを新たに作成してそこに記述する

@kmycode kmycode added this to the kb12.0 milestone Mar 21, 2024
@kmycode kmycode changed the title Kbtopic 647 ng words Change: #647 NGワードの入力フォーム Mar 21, 2024
@kmycode kmycode marked this pull request as draft March 21, 2024 06:14
@kmycode kmycode marked this pull request as ready for review March 25, 2024 00:18
@kmycode kmycode merged commit 95ab1f7 into kb_development Mar 25, 2024
45 checks passed
@kmycode kmycode deleted the kbtopic-647-ng-words branch March 25, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment