Skip to content
This repository was archived by the owner on Jun 14, 2019. It is now read-only.

Commit 2f418bd

Browse files
committed
feat(wrapper): add support for eventbus.send() arg failureHandler
The eventbus of Vert.x 3 add support for an additional argument `failureHandler`. While this will be not used from this module (due backwards compatiblity), the wrapper will delegate such argument blindly. Relates #42
1 parent 3598dfd commit 2f418bd

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/lib/service/delegate/Live.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,7 @@ class LiveDelegate extends BaseDelegate {
250250
deferred.reject();
251251
}), timeout, 1);
252252
// Send message
253+
// TODO after dropping support for Vert.x < v3, this can be enriched with failureHandler
253254
this.eventBus.send(address, message, (reply) => {
254255
this.$interval.cancel(timer); // because it's resolved
255256
deferred.resolve(reply);

src/lib/wrapper/Base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class BaseWrapper {
1010

1111
login(username, password, replyHandler) {}
1212

13-
send(address, message, replyHandler) {}
13+
send(address, message, replyHandler, failureHandler) {}
1414

1515
publish(address, message) { }
1616

src/lib/wrapper/Eventbus.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,11 @@ class EventbusWrapper extends BaseWrapper {
236236
* @param {string} address target address
237237
* @param {object} message payload message
238238
* @param {function=} replyHandler optional callback
239+
* @param {function=} failureHandler optional callback (since Vert.x 3.0.0)
239240
*/
240-
send(address, message, replyHandler) {
241+
send(address, message, replyHandler, failureHandler) {
241242
if (this.instance) {
242-
this.instance.send(address, message, replyHandler);
243+
this.instance.send(address, message, replyHandler, failureHandler);
243244
}
244245
}
245246

0 commit comments

Comments
 (0)