Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-plane]: Bump org.scala-lang:scala-reflect from 2.12.15 to 2.13.12 in /data-plane #3428

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 24, 2023

Bumps org.scala-lang:scala-reflect from 2.12.15 to 2.13.12.

Release notes

Sourced from org.scala-lang:scala-reflect's releases.

Scala 2.13.12

The Scala team at Lightbend is pleased to announce Scala 2.13.12.

The following changes are highlights of this release:

Feature: Quickfixes

For some errors and warnings, the compiler now suggests an edit that could fix the issue. Tooling such as IDEs can then offer the edits, or the compiler itself will make the change if run again with -quickfix.

  • Implement quickfixes, aka actionable diagnostics (via CodeAction) (#10406 by @​eed3si9n)
  • Add -quickfix compiler option to apply quickfixes to source files (#10482 by @​lrytz)
  • Add quickfixes to some warnings and errors (#10484 by @​lrytz)

Align with Scala 3

  • Emit migration warnings under -Xsource:3 as fatal warnings, not errors (#10439 by @​som-snytt, #10511)
    • -Xmigration will demote the errors to warnings
    • -Wconf:cat=scala3-migration:s will silence these errors/warnings altogether
  • Warn about @elidable under -Xsource:3 (#10377 by @​som-snytt)

Collections

  • IndexedSeq#head now throws NoSuchElementException (not IndexOutOfBoundsException) (#10392 by @​som-snytt)

Regression fixes

Scaladoc tool changes

Library authors should be aware that the behavior of -doc-source-url has changed, as follows:

You may need to adjust your build accordingly, to avoid generating broken source links.

Tooling

The following change is mainly of concern to tooling maintainers.

Other notable changes

For the complete 2.13.12 change lists, see all merged PRs and all closed bugs.

Compatibility

As usual for our minor releases, Scala 2.13.12 is binary-compatible with the whole Scala 2.13 series.

... (truncated)

Commits
  • 80514f7 Merge pull request #10524 from lrytz/t12858
  • 96d74ac Fix spurious "nullary overrides nilary" warning
  • f7e30a6 Merge pull request #10510 from lrytz/beanNilaryOverrideFix
  • 9bf2653 Merge pull request #10511 from lrytz/source3warn
  • 35160d4 Merge pull request #10520 from lrytz/pr10512
  • b079015 Merge pull request #10521 from lrytz/filteringQuickfix
  • 751a631 improve nilary/nullary override message
  • 6cbff91 Merge pull request #10513 from lrytz/t12850
  • 361a97c strip [quickfixable] for message comparison in FilteringReporter
  • f5b4357 Turn more Xsource:3 errors into fatal warnings
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [org.scala-lang:scala-reflect](https://github.com/scala/scala) from 2.12.15 to 2.13.12.
- [Release notes](https://github.com/scala/scala/releases)
- [Commits](scala/scala@v2.12.15...v2.13.12)

---
updated-dependencies:
- dependency-name: org.scala-lang:scala-reflect
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 24, 2023
@knative-prow knative-prow bot requested review from creydr and matzew October 24, 2023 20:25
@knative-prow knative-prow bot added area/data-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #3428 (0d657f7) into main (ad22a19) will increase coverage by 3.09%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3428      +/-   ##
============================================
+ Coverage     58.48%   61.57%   +3.09%     
- Complexity        0      762     +762     
============================================
  Files            91      181      +90     
  Lines          9319    12396    +3077     
  Branches          0      265     +265     
============================================
+ Hits           5450     7633    +2183     
- Misses         3433     4161     +728     
- Partials        436      602     +166     
Flag Coverage Δ
java-unittests 70.94% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 90 files with indirect coverage changes

@creydr
Copy link
Contributor

creydr commented Oct 25, 2023

/retest

1 similar comment
@matzew
Copy link
Contributor

matzew commented Oct 25, 2023

/retest

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dependabot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@creydr
Copy link
Contributor

creydr commented Oct 25, 2023

/retest

2 similar comments
@creydr
Copy link
Contributor

creydr commented Oct 25, 2023

/retest

@creydr
Copy link
Contributor

creydr commented Oct 25, 2023

/retest

@Cali0707
Copy link
Member

/test channel-integration-tests-sasl-plain

@creydr
Copy link
Contributor

creydr commented Oct 25, 2023

/retest

1 similar comment
@creydr
Copy link
Contributor

creydr commented Oct 25, 2023

/retest

@knative-prow knative-prow bot merged commit 82261a3 into main Oct 25, 2023
33 checks passed
@dependabot dependabot bot deleted the dependabot/maven/data-plane/main/org.scala-lang-scala-reflect-2.13.12 branch October 25, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane dependencies Pull requests that update a dependency file java Pull requests that update Java code lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants