-
Notifications
You must be signed in to change notification settings - Fork 82
Conversation
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #1259 +/- ##
=======================================
Coverage 74.93% 74.93%
=======================================
Files 128 128
Lines 9017 9017
=======================================
Hits 6757 6757
Misses 2029 2029
Partials 231 231 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Can we remove them from the released YAMLs: https://github.com/knative-sandbox/eventing-kafka/blob/07af4e8e1ee3e5469b94073bc497b2619c310650/hack/release.sh#L26-L34 |
Related discussion: https://knative.slack.com/archives/C9JP909F0/p1667841421355339 |
If the components are specific to certain packages you can probably mark those packages are deprecated using godoc |
Should we continue on this? We have some CI upgrade test failures, as it uses some deprecated API version for PodDisruptionBudget and HPA (see #1287 for example). Or would we first have to deprecate but keep them in the yamls for a few releases? |
@creydr yes, please, we cannot move forward with the release (yesterday) without this |
See #1327 |
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
Proposed Changes
Release Note
Docs