-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broker ingress and Dispatcher now uses the protocol binding instead of json to process events #751
Broker ingress and Dispatcher now uses the protocol binding instead of json to process events #751
Conversation
Codecov Report
@@ Coverage Diff @@
## main #751 +/- ##
==========================================
- Coverage 75.20% 74.84% -0.37%
==========================================
Files 36 35 -1
Lines 2654 2544 -110
==========================================
- Hits 1996 1904 -92
+ Misses 588 576 -12
+ Partials 70 64 -6
Continue to review full report at Codecov.
|
b27ea9c
to
c8a46a9
Compare
…ces + recreated perf test images
…hmarks images + readme
…ntry point for the source in the conformance tests, the changes to the broker to support this are going to be made in another commit + created source perf test results and published images, the performance gains while using the binary protocol binding vs json manipulation seems to be significant memorywise
using ce protocol binding to get msg from a rabbitmq msg delivery
… does not support header on its test channels excluding adapter from the golangci-lint while wabbit is been removed from the repo added missing ce attributes to msg headers in ingres added source to message header so it will be filtered appropriately added support for timestamp in the ingress formating trying different approach with cloudevents and filters
adb2b61
to
779cd76
Compare
fixed broker perf test setup + removed unused file + rebased
removed ununsed header using the contentype header avoid using rabbitmq specific headers when translating rabbitmq messages to cloudevents + small refactor on the dispatcher
… rabbitmq message + fixed malformed json in e2e test producer fixing e2e and conformance tests to match expected output removed unnecesary cast
2a82180
to
c839f5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes. just some minor things
…stead of the one defined by the test
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gab-satchi, gabo1208 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merge after #750
Changes
/kind enhancement performance
Fixes #
Release Note