Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CORS policy values only for when HTTPProxy associated with external visibility #1088

Merged
merged 2 commits into from
May 14, 2024

Conversation

izabelacg
Copy link
Member

@izabelacg izabelacg commented May 13, 2024

Changes

  • 🧹 Currently, when setting CORS policy in config-contour, all HTTPProxies are modified to include the CORS settings.
    This PR modifies the code to set CORS policy values only for when HTTPProxy is associated with external visibility.
  • add test to confirm CORS policy settings are not included in HTTPProxy resources with cluster local visibility.

/kind cleanup

Apply CORS policy on external routes

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2024
@knative-prow knative-prow bot requested review from KauzClay and ReToCode May 13, 2024 18:50
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (820cd7c) to head (f8bacc3).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
- Coverage   94.06%   93.92%   -0.14%     
==========================================
  Files          11       11              
  Lines         893      708     -185     
==========================================
- Hits          840      665     -175     
+ Misses         32       22      -10     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
Copy link

knative-prow bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: izabelacg, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@knative-prow knative-prow bot merged commit a0f7039 into knative-extensions:main May 14, 2024
24 checks passed
@dprotaso
Copy link
Contributor

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #1089

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants