Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the config-gateway format #701

Merged
merged 7 commits into from
Apr 22, 2024

Conversation

dprotaso
Copy link
Contributor

This puts the configuration in line with what we did in net-istio - details are here knative-extensions/net-istio#1247

but tl;dr we changed the gateway config to take a list of gateways. This will allow us to do label filtering of gateways in the future without breaking the config format.

For now we restrict the number of gateways to a single one.

Copy link

knative-prow bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 78.29%. Comparing base (cd525ad) to head (52351d2).
Report is 33 commits behind head on main.

Files Patch % Lines
pkg/reconciler/ingress/ingress.go 64.70% 6 Missing ⚠️
pkg/reconciler/ingress/config/gateway.go 94.28% 4 Missing ⚠️
pkg/reconciler/ingress/config/store.go 0.00% 3 Missing ⚠️
pkg/reconciler/ingress/lister.go 88.88% 1 Missing ⚠️
pkg/reconciler/ingress/reconcile_resources.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #701       +/-   ##
===========================================
+ Coverage   66.97%   78.29%   +11.31%     
===========================================
  Files          15       16        +1     
  Lines         863     1230      +367     
===========================================
+ Hits          578      963      +385     
+ Misses        254      229       -25     
- Partials       31       38        +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg
Copy link
Member

/lgtm
/hold for tests

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@dprotaso
Copy link
Contributor Author

Reset PR to pull in latest fixes in the main branch

@dprotaso
Copy link
Contributor Author

all good now
@izabelacg PTAL again

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@dprotaso
Copy link
Contributor Author

/override "Generate some code!"
/override "style / suggester / github_actions"

Workaround for prow merging being broken - knative/infra#411

Copy link

knative-prow bot commented Apr 22, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: Generate some code!, style / suggester / github_actions

In response to this:

/override "Generate some code!"
/override "style / suggester / github_actions"

Workaround for prow merging being broken - knative/infra#411

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@knative-prow knative-prow bot merged commit 3012937 into knative-extensions:main Apr 22, 2024
31 checks passed
@dprotaso dprotaso deleted the config-changes branch April 22, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants