-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the config-gateway format #701
change the config-gateway format #701
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
===========================================
+ Coverage 66.97% 78.29% +11.31%
===========================================
Files 15 16 +1
Lines 863 1230 +367
===========================================
+ Hits 578 963 +385
+ Misses 254 229 -25
- Partials 31 38 +7 ☔ View full report in Codecov by Sentry. |
/lgtm |
Reset PR to pull in latest fixes in the |
all good now /hold cancel |
/override "Generate some code!" Workaround for prow merging being broken - knative/infra#411 |
@dprotaso: Overrode contexts on behalf of dprotaso: Generate some code!, style / suggester / github_actions In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
This puts the configuration in line with what we did in
net-istio
- details are here knative-extensions/net-istio#1247but tl;dr we changed the gateway config to take a list of gateways. This will allow us to do label filtering of gateways in the future without breaking the config format.
For now we restrict the number of gateways to a single one.