Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualService gets validation error - unknown field "websocketUpgrade" in io.istio.networking.v1beta1.VirtualService.spec.http #53

Closed
nak3 opened this issue Mar 21, 2020 · 0 comments · Fixed by #54

Comments

@nak3
Copy link
Contributor

nak3 commented Mar 21, 2020

steps to reproduce

step-0. Deploy istio (I used istio-1.5 with mesh&galley)
step-1. Deploy any ksvc
step-2. Edit virtualservice
$ kubectl edit vs hello-example-ingress
step-3. Close without edit (by :q).

Actual result

Then, you get following error:

# virtualservices.networking.istio.io "hello-example-ingress" was not valid:
# * : Invalid value: "The edited file failed validation": [ValidationError(VirtualService.spec.http[0]): unknown field "websocketUpgrade" in io.istio.networking.v1beta1.VirtualService.spec.http, ValidationError(VirtualService.spec.http[1]): unknown field "websocketUpgrade" in io.istio.networking.v1beta1.VirtualService.spec.http]

Expected

The websocketUpgrade is already deprecated, so we should remove it.

https://github.com/knative/net-istio/blob/2833eeb85bda6c5ead740a4b871ce95c5d520a8e/vendor/istio.io/api/networking/v1alpha3/virtual_service.pb.go#L520-L522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant