Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enabling virtualservice status breaks update tests #585

Closed
dprotaso opened this issue Apr 6, 2021 · 5 comments · Fixed by #1125
Closed

enabling virtualservice status breaks update tests #585

dprotaso opened this issue Apr 6, 2021 · 5 comments · Fixed by #1125
Assignees
@KauzClay
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@dprotaso
Copy link
Contributor

dprotaso commented Apr 6, 2021 •
edited
Loading

I've observed the virtual service status.observedGeneration doesn't change so the net-istio reconciler thinks it's stale and doesn't update. I'm going to disable this flag for the latests tests for now

I realize the config-istio get's cleared when we ko'd the config

So because of this we never really ran e2e tests with the virtual status enabled - thus I think this is a legit bug.

Originally posted by @dprotaso in #583 (comment)
@dprotaso dprotaso changed the title enable-virtualservice-status breaks update tests enabling virtualservice status breaks update tests Apr 6, 2021
@dprotaso
Copy link
Contributor Author

dprotaso commented Apr 6, 2021

I created an upstream issue: istio/istio#31931

@dprotaso dprotaso mentioned this issue Apr 6, 2021
Merged
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2021
@dprotaso
Copy link
Contributor Author

dprotaso commented Jul 6, 2021

/lifecycle frozen

@knative-prow-robot knative-prow-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 6, 2021
@nak3 nak3 mentioned this issue Nov 25, 2021
Merged
knative-prow-robot pushed a commit that referenced this issue Nov 25, 2021
@nak3
Disable enable-virtualservice-status on istio-head test (#818)
23b2fcb 
* remove script

* Disable enable-virtualservice-status on istio-head test

Istio head test keeps failing as https://testgrid.k8s.io/r/knative-own-testgrid/serving#istio-head-no-mesh
This is most probably due to `enable-virtualservice-status`.

This patch changes:
- to disables enable-virtualservice-status until #585 was fixed.
- to update Istio version to Stable 1.11.4 and Latest 1.12.0.

* Drop extra template

* Drop config-istio.yaml from istio-head
@carlisia carlisia mentioned this issue Aug 10, 2022
Closed
@dprotaso
Copy link
Contributor Author

dprotaso commented Jun 2, 2023 •
edited
Loading

/good-first-issue

We should remove this functionality from net-istio - and the flag

https://github.com/knative-sandbox/net-istio/blob/77e1cf889b1757f503744baa22a447c9d82f72c2/config/400-config-istio.yaml#L67-L70

@knative-prow
Copy link

knative-prow bot commented Jun 2, 2023

@dprotaso:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

We should remove this functionality from net-istio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 2, 2023
@KauzClay KauzClay self-assigned this Jun 2, 2023
@KauzClay KauzClay mentioned this issue Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KauzClay KauzClay

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove enable-virtualservice-status config KauzClay/net-istio
3 participants
@dprotaso @KauzClay @knative-prow-robot