Do not use FromContextOrDefaults() in translateIngress()

[nak3]

Currently, there are some places use FromContextOrDefaults() in translateIngress() function such as:

https://github.com/knative-sandbox/net-kourier/blob/649db2781d60dd6a5580806194b3df5378118ed9/pkg/generator/ingress_translator.go#L195
https://github.com/knative-sandbox/net-kourier/blob/649db2781d60dd6a5580806194b3df5378118ed9/pkg/generator/ingress_translator.go#L268

FromContextOrDefaults() returns the default value in config-network so controller temporarily creates a envoy configuration with unexpected configuration.
For example, internal-encryption is disabled by default so it creates envoy configuration without internal-encryption even if users enabled.

[ReToCode]

@nak3 do you know why we generate an initial envoy snapshot when the controller is constructed, instead just doing that on the first reconcile event? Is that so envoy can start?

[nak3]

Sorry, I am not familiar with it but I think it was implemented as there is an issue that controller sends an incomplete configuration to an already running gateway container as per the following PRs.

• Warm the internal config cache to avoid sending an empty snapshot. #72
• Initialize the envoy snapshot without waiting for cache sync #137
• Optimize cache warmup on startup #276

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[ReToCode]

/remove-lifecycle stale