Set anti-affinity for receiver deployment #483
Conversation
knative-prow-robot
added
the
size/S
arghya88
changed the title
arghya88
changed the title
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
=========================================
Coverage 76.79% 76.79%
Complexity 269 269
=========================================
Files 59 59
Lines 1969 1969
Branches 82 82
=========================================
Hits 1512 1512
Misses 342 342
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks!
There is another deployment to set anti-affinity: https://github.com/knative-sandbox/eventing-kafka-broker/blob/master/data-plane/config/sink/template/500-receiver.yaml
knative-prow-robot
added
the
approved
|
Can you add a release note? Something like: /kind enhancement |
Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
arghya88
force-pushed
the
receiver-antiaffinity
branch
from
fff96b9
to
2a57f90
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arghya88, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
…sions#2773) (knative-extensions#483) Since we create the contract ConfigMaps in the Consumer reconciler but the scheduler is called in the ConsumerGroup reconciler and it fails with "not enough pod replicas" when the data plane pods are in pending state. This is not evident in our CI but it might be a signal of an edge case caused by a certain sequence of events. In this PR, I'm creating ConfigMaps before calling the scheduler in the ConsumerGroup reconciler so that the pods can become ready before the scheduler verifies which pods are available to schedule vpods. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Arghya Sadhu arghya88@gmail.com
Fixes #482
Proposed Changes
Release Note
Docs