acks=all #827
Merged
acks=all #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
requested review from
tcnghia and
fallback-notification-blocker
knative-prow-robot
added
area/data-plane
size/XS
Codecov Report
@@ Coverage Diff @@
## main #827 +/- ##
=======================================
Coverage 71.67% 71.67%
=======================================
Files 28 28
Lines 1257 1257
=======================================
Hits 901 901
Misses 277 277
Partials 79 79 Continue to review full report at Codecov.
|
pierDipi
approved these changes
Apr 21, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
matzew
pushed a commit
to matzew/eventing-kafka-broker
that referenced
this pull request
Oct 11, 2023
knative-extensions#827) Signed-off-by: Calum Murray <cmurray@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Same as #824, for kafka sink
Proposed Changes
Release Note
Docs