Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acks=all #827

Conversation

slinkydeveloper
Copy link
Contributor

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Same as #824, for kafka sink

Proposed Changes

  • 🐛 Now the producer will wait for all ISR replicas ack

Release Note

In Kafka Sink, now the kafka producer will wait for all ISR replicas ack

Docs

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper requested review from a team as code owners April 21, 2021 12:16
@slinkydeveloper slinkydeveloper requested review from tcnghia and a user April 21, 2021 12:16
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 21, 2021
@knative-prow-robot knative-prow-robot added area/data-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2021
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #827 (5d99cc1) into main (62fe1c8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   71.67%   71.67%           
=======================================
  Files          28       28           
  Lines        1257     1257           
=======================================
  Hits          901      901           
  Misses        277      277           
  Partials       79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fe1c8...5d99cc1. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021
@knative-prow-robot knative-prow-robot merged commit b6e0a41 into knative-extensions:main Apr 21, 2021
matzew pushed a commit to matzew/eventing-kafka-broker that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants