[kn-source-github] first version of the kn-source-github plugin #46

maximilien · 2020-06-10T22:32:20Z

Includes:

create, update, delete, list commands
first version of unit tests
first version of integration tests

Missing:

more integration tests. Especially verifying setup of eventing source
make IT independent of github user
resolve vendor as per new fashion

Fixes #10 and #34

Includes: * create, update, delete, list commands * first version of unit tests * first version of integration tests Missing: * more integration tests. Especially verifying setup of eventing source * make IT independent of github user * resolve vendor as per new fashion

knative-prow-robot · 2020-06-10T22:32:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [maximilien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mattmoor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

plugins/source-github/vendor/github.com/cpuguy83/go-md2man/v2/md2man/roff.go

plugins/source-github/vendor/github.com/russross/blackfriday/v2/README.md

mattmoor · 2020-06-10T22:49:09Z

plugins/source-github/vendor/knative.dev/client/lib/test/flags.go

@@ -0,0 +1,42 @@
+/*
+Copyright 2019 The Knative Authors


Incorrect copyright year:

Suggested change

Copyright 2019 The Knative Authors

Copyright 2020 The Knative Authors

mattmoor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor · 2020-06-10T22:52:12Z

plugins/source-github/hack/generate_docs.go

+	if err != nil {
+		fmt.Fprintln(os.Stdout, err)
+		os.Exit(1)
+	}


Format Go code:

Suggested change

}

}

}

maximilien · 2020-07-02T16:32:39Z

/hold

knative-prow-robot · 2020-09-17T08:16:17Z

@daisy-ycguo: The /test command needs one or more targets.
The following commands are available to trigger jobs:

/test pull-knative-client-contrib-build-tests
/test pull-knative-client-contrib-unit-tests
/test pull-knative-client-contrib-integration-tests

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

daisy-ycguo · 2020-09-17T08:17:32Z

/test all

daisy-ycguo · 2020-09-17T08:20:05Z

plugins/source-github/test/e2e/basic_workflow_test.go

+	assert.NilError(t, err)
+
+	t.Log("kn-source_github create 'source-name' with 'sink-name'")
+	e2eTest.ghSourceCreate(t, r, "source-name", "sink-name")


I wonder where did you create the sink sink-name. I run test locally, and it reported:

$ kn source_github create source-name --sink sink-name --namespace kne2etests0 --namespace kne2etests0 f.KnSourceParams(): &types.KnSourceParams{KnParams:commands.KnParams{Output:io.Writer(nil), KubeCfgPath:"", ClientConfig:(*clientcmd.DeferredLoadingClientConfig)(0xc0000ec640), NewServingClient:(func(string) (v1.KnServingClient, error))(0x1eb7e20), NewSourcesClient:(func(string) (v1alpha2.KnSourcesClient, error))(0x1eb7ea0), NewEventingClient:(func(string) (v1alpha1.KnEventingClient, error))(0x1eb7f20), NewDynamicClient:(func(string) (dynamic.KnDynamicClient, error))(0x1eb7fa0), LogHTTP:false, fixedCurrentNamespace:""}, SinkFlag:flags.SinkFlags{sink:"sink-name"}} panic: runtime error: invalid memory address or nil pointer dereference

I think it is because that sink-name is not created.

I wonder if there is a way to set required flags, because kn source_github create source-name --sink sink-name --namespace kne2etests0 shall report error because no GitHub source parameters is provided, logically speaking.

daisy-ycguo · 2020-09-17T08:35:54Z

@maximilien Hello, dr.max. Currently, the integration test runs nothing, because you don't have an e2e-tests.sh under plugins/source-github/test, just a local-e2e-tests.sh. The integration test framework used by client-contrib is designed to call plugins/source-github/test/e2e-tests.sh for the e2e test of every plugin. So please add a plugins/source-github/test/e2e-tests.sh to your plugin. You may just copy the same of local-e2e-tests.sh. Thanks.

maximilien · 2020-09-24T20:20:41Z

Thanks @daisy-ycguo will do.

knative-prow-robot · 2020-10-20T01:14:17Z

@maximilien: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot · 2021-03-08T17:37:25Z

@maximilien: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-client-contrib-integration-tests	`897f796`	link	`/test pull-knative-client-contrib-integration-tests`
pull-knative-client-contrib-build-tests	`897f796`	link	`/test pull-knative-client-contrib-build-tests`
pull-knative-client-contrib-unit-tests	`897f796`	link	`/test pull-knative-client-contrib-unit-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 10, 2020

knative-prow-robot requested review from evankanderson and navidshaikh June 10, 2020 22:32

knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 10, 2020

maximilien changed the title ~~First version of the kn-source-github plugin~~ [kn-source-github] first version of the kn-source-github plugin Jun 10, 2020

mattmoor reviewed Jun 10, 2020

View reviewed changes

formatting changes

897f796

mattmoor reviewed Jun 10, 2020

View reviewed changes

plugins/source-github/vendor/github.com/cpuguy83/go-md2man/v2/md2man/roff.go Show resolved Hide resolved

plugins/source-github/vendor/github.com/russross/blackfriday/v2/README.md Show resolved Hide resolved

mattmoor reviewed Jun 10, 2020

View reviewed changes

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2020

maximilien mentioned this pull request Sep 9, 2020

[kn-source-github] kn plugin for managing github event sources #34

Open

4 tasks

daisy-ycguo reviewed Sep 17, 2020

View reviewed changes

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2020

Base automatically changed from master to main March 8, 2021 17:37

Update README.md

43bda9e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kn-source-github] first version of the kn-source-github plugin #46

[kn-source-github] first version of the kn-source-github plugin #46

maximilien commented Jun 10, 2020 •

edited

Loading

knative-prow-robot commented Jun 10, 2020

mattmoor left a comment

mattmoor Jun 10, 2020

mattmoor left a comment

mattmoor Jun 10, 2020

maximilien commented Jul 2, 2020

knative-prow-robot commented Sep 17, 2020

daisy-ycguo commented Sep 17, 2020

daisy-ycguo Sep 17, 2020

daisy-ycguo Sep 17, 2020 •

edited

Loading

daisy-ycguo commented Sep 17, 2020 •

edited

Loading

maximilien commented Sep 24, 2020

knative-prow-robot commented Oct 20, 2020

knative-prow-robot commented Mar 8, 2021

	Copyright 2019 The Knative Authors
	Copyright 2020 The Knative Authors

[kn-source-github] first version of the kn-source-github plugin #46

Are you sure you want to change the base?

[kn-source-github] first version of the kn-source-github plugin #46

Conversation

maximilien commented Jun 10, 2020 • edited Loading

knative-prow-robot commented Jun 10, 2020

mattmoor left a comment

Choose a reason for hiding this comment

mattmoor Jun 10, 2020

Choose a reason for hiding this comment

mattmoor left a comment

Choose a reason for hiding this comment

mattmoor Jun 10, 2020

Choose a reason for hiding this comment

maximilien commented Jul 2, 2020

knative-prow-robot commented Sep 17, 2020

daisy-ycguo commented Sep 17, 2020

daisy-ycguo Sep 17, 2020

Choose a reason for hiding this comment

daisy-ycguo Sep 17, 2020 • edited Loading

Choose a reason for hiding this comment

daisy-ycguo commented Sep 17, 2020 • edited Loading

maximilien commented Sep 24, 2020

knative-prow-robot commented Oct 20, 2020

knative-prow-robot commented Mar 8, 2021

maximilien commented Jun 10, 2020 •

edited

Loading

daisy-ycguo Sep 17, 2020 •

edited

Loading

daisy-ycguo commented Sep 17, 2020 •

edited

Loading