This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Update cluster-setup to compile kn properly #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
approved
rhuss
added
do-not-merge/hold
knative-prow-robot
added
the
size/XL
mattmoor
reviewed
Jun 17, 2020
knative-prow-robot
added
approved
mattmoor
reviewed
Jun 17, 2020
mattmoor
reviewed
Jun 17, 2020
daisy-ycguo
suggested changes
Jun 17, 2020
There was a problem hiding this comment.
Some errors during setting up client kn in the output of integration test:
test/common.sh: line 70: pushd: /tmp/kn-build.wDjOa7: Not a directory
fatal: destination path '.' already exists and is not an empty directory.
test/common.sh: line 72: hack/build.sh: No such file or directory
cp: cannot stat 'kn': No such file or directory
test/common.sh: line 74: popd: directory stack empty
mattmoor
reviewed
Jun 17, 2020
mattmoor
reviewed
Jun 17, 2020
|
|
||
| ```bash | ||
| # kubectl get rc [tab][tab] | ||
| backend frontend database |
There was a problem hiding this comment.
Remove trailing whitespace:
Suggested change
| backend frontend database | |
| backend frontend database |
rhuss
changed the title
rhuss
removed
the
do-not-merge/hold
|
@daisy-ycguo I think we can merge that and then the issue on the non-vendor PR would be gone, too. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, update hello plugin to cobra 1.0