Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make wait, no-wait and async flags per bool var CLI convention #802

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Make wait, no-wait and async flags per bool var CLI convention #802

merged 4 commits into from
Apr 14, 2020

Conversation

navidshaikh
Copy link
Collaborator

@navidshaikh navidshaikh commented Apr 14, 2020 •
edited
Loading

Fixes #800

Description

  • Deprecated bool vars can be supported for CLI convention
  • Bind --async flag value to --no-wait
➜  kn service create foo --image gcr.io/foo/bar --async --no-wait
only one of (DEPRECATED) --async, --wait and --no-wait may be specified

➜  kn service create foo --image gcr.io/foo/bar --async --wait   
only one of (DEPRECATED) --async, --wait and --no-wait may be specified

➜  kn service create foo --image gcr.io/foo/bar --async --no-wait --wait
only one of (DEPRECATED) --async, --wait and --no-wait may be specified

➜  kn service create foo --image gcr.io/foo/bar --async=false           
use --wait instead of providing "false" to --async

/lint

@navidshaikh
Make wait, no-wait and async flags per bool var CLI convention
b8417a3 
 Fixes knative#800

 - Deprecated bool vars can be supported for CLI convention
 - Bind --async flag value to --no-wait
 - Only one flag among [wait, no-wait, async] can be provided, else raise an error
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 14, 2020
knative-prow-robot
knative-prow-robot reviewed Apr 14, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 0 warnings.

In response to this:

Fixes #800

Description

  • Deprecated bool vars can be supported for CLI convention
  • Bind --async flag value to --no-wait
  • Only one flag among [wait, no-wait, async] can be provided, else raise an error

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2020
@navidshaikh navidshaikh requested review from dsimansk and rhuss and removed request for cppforlife and evankanderson April 14, 2020 18:14
rhuss
rhuss requested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except I think the conditional when checking for --async can be simpler (see comment).

pkg/kn/flags/bool.go Outdated Show resolved Hide resolved
pkg/kn/flags/bool.go Outdated Show resolved Hide resolved
pkg/kn/flags/bool.go Outdated Show resolved Hide resolved
pkg/kn/flags/bool.go Outdated Show resolved Hide resolved
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/flags/bool.go 87.8% 90.0% 2.2

rhuss
rhuss approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@navidshaikh navidshaikh added the backport/candidate Consider this PR to be backported to the release branch label Apr 14, 2020
@knative-prow-robot knative-prow-robot merged commit 46ecdcc into knative:master Apr 14, 2020
@navidshaikh navidshaikh deleted the pr/fix-800 branch April 14, 2020 19:40
rhuss pushed a commit to rhuss/knative-client that referenced this pull request Apr 15, 2020
@navidshaikh @rhuss
Make wait, no-wait and async flags per bool var CLI convention (knati…
d52a5aa 
…ve#802)

* Make wait, no-wait and async flags per bool var CLI convention

 Fixes knative#800

 - Deprecated bool vars can be supported for CLI convention
 - Bind --async flag value to --no-wait
 - Only one flag among [wait, no-wait, async] can be provided, else raise an error

* Simplify conditionals

* Add unit tests for deprecated flag async

* Fix a typo
@rhuss rhuss mentioned this pull request Apr 15, 2020
Merged
knative-prow-robot pushed a commit that referenced this pull request Apr 15, 2020
@rhuss @maximilien
@dsimansk @navidshaikh @MIBc @itsmurugappan
Pr/release 0.13.2 backports (#806)
b67f302 
* (refactor) address the e2e extract / refactor of issue #763 (#765)

* (refactor) address the e2e extract / refactor of issue #763

* various updates to address reviewers feedback

* renamed lib/test/integration to lib/test and package to test

Signed-off-by: Roland Huß <roland@ro14nd.de>
# Conflicts:
#	CHANGELOG.adoc
#	test/e2e/service_export_import_apply_test.go
#	test/e2e/trigger_test.go

* fix(plugin): Fix plugin lookup with file ext on Windows (#774)

* fix(plugin): Fix plugin lookup with file ext on Windows

* chore: Update changelog

* fix: Reflect review feedback

* fix: Reflect review feedback and add future todo

Signed-off-by: Roland Huß <roland@ro14nd.de>
# Conflicts:
#	CHANGELOG.adoc

* fix(issue #762): correct error message when updating service (#778)

* fix(issue #762): correct error message when updating service

* correct message when updating service and passing many names
* fix issue with TestServiceUpdateWithMultipleImages running create vs update

* * added TestServiceDescribeWithMultipleNames
* added TestServiceCreateWithMultipleNames
* fix error message for service delete since many names can be passed

* Use vendored deps while running e2e locally (#783)

Also set GO111MODULE=on unconditionally

* Update sink binding create usage string (#785)

* Add "--target-utilization" to manage "autoscaling.knative.dev/targetUtilizationPercentage" annotation (#788)

* Support setting "autoscaling.knative.dev/targetUtilizationPercentage" annotation.

Signed-off-by: Roland Huß <roland@ro14nd.de>
# Conflicts:
#	test/e2e/service_options_test.go

* Remove the delete propagation flag (#770)

* Remove the delete propagation flag

In it's current state it now takes me about 25 seconds for the `kn delete`
to complete. Before #682 it used to be
almost immediate. This is because we now pass in the
`DeletePropagationBackground` flag. I believe this is a mistake, not only
because of the 20+ seconds of additional time to delete things, but IMO
the CLI should talk to the server in the same way regardless of the --wait
flag. That flag should just be a CLI thing to indicate if the user wants the CLI
to wait for the server to complete but not HOW the server should do the delete.

Signed-off-by: Doug Davis <dug@us.ibm.com>

* try just tweaking the --no-wait flag

Signed-off-by: Doug Davis <dug@us.ibm.com>

* Fix error when output is set to name (#775)

* fix error when output is set to name

* add e2e test

* change to flags/listprint.go

Signed-off-by: Roland Huß <roland@ro14nd.de>
# Conflicts:
#	test/e2e/basic_workflow_test.go

* Show all revisions when run `service describe -v` (#790)

* The `kn service describe -v` command shows repetitive revisions, because
  the revision would be covered by next one.

* Fix resource listing with -oname flag (#799)

* Fix resource listing with -oname flag

* add e2e tests

Signed-off-by: Roland Huß <roland@ro14nd.de>
# Conflicts:
#	test/e2e/ping_test.go
#	test/e2e/revision_test.go
#	test/e2e/route_test.go
#	test/e2e/source_apiserver_test.go
#	test/e2e/source_binding_test.go
#	test/e2e/trigger_test.go

* Make wait, no-wait and async flags per bool var CLI convention (#802)

* Make wait, no-wait and async flags per bool var CLI convention

 Fixes #800

 - Deprecated bool vars can be supported for CLI convention
 - Bind --async flag value to --no-wait
 - Only one flag among [wait, no-wait, async] can be provided, else raise an error

* Simplify conditionals

* Add unit tests for deprecated flag async

* Fix a typo

* e2e: Foreground delete for revisions and services in e2e (#794)

* e2e: Foreground delete for revisions and services in e2e

 to avoid any race conditions and flakes

* Use --wait instead of --no-wait=false

Signed-off-by: Roland Huß <roland@ro14nd.de>
# Conflicts:
#	test/e2e/basic_workflow_test.go
#	test/e2e/revision_test.go

* e2e: Run tekton e2e against pipeline v0.11.1 (#803)

* Use buildah task from master branch and paramterize FORMAT

* Configure pipeline v0.11.1

* DNM: Run tekton e2e in this PR

* Revert "DNM: Run tekton e2e in this PR"

This reverts commit 903f5be.

* Update CHANGELOG for v0.13.2 (#804)

* Pin serving to v0.13.2 and update version command (#797)

* Pin serving v0.13.2 dep to v0.13.2

* Update version command

 now points to serving v0.13.2 and eventing v0.13.6

* Copy go.sum as generated in CI

Signed-off-by: Roland Huß <roland@ro14nd.de>
# Conflicts:
#	go.mod
#	go.sum
#	vendor/modules.txt

* add missing vendored files

* fixed error reporting for traffics tests

* Updated test

* fix formatting

* e2e for service export (#739)

* e2e for service export

* e2e for service export

* e2e for service export

* e2e for service export

* e2e for service export

Signed-off-by: Roland Huß <roland@ro14nd.de>
# Conflicts:
#	test/e2e/service_export_import_apply_test.go

Co-authored-by: dr.max <maxim@us.ibm.com>
Co-authored-by: David Simansky <dsimansk@redhat.com>
Co-authored-by: Navid Shaikh <nshaikh@redhat.com>
Co-authored-by: Lv Jiawei <lvjiawei@cmss.chinamobile.com>
Co-authored-by: Doug Davis <dug@us.ibm.com>
Co-authored-by: Ying Chun Guo <guoyingc@cn.ibm.com>
Co-authored-by: Murugappan Chetty <itsmurugappan@gmail.com>
@navidshaikh navidshaikh added backport/pr A backport PR which is target to a release branch. and removed backport/candidate Consider this PR to be backported to the release branch labels Apr 20, 2020
@rhuss rhuss removed the backport/pr A backport PR which is target to a release branch. label Apr 20, 2020
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@chaodaiG @knative-prow-robot
update prow componenets to v20190517-bb7028b16 (knative#802)
199fc8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@rhuss rhuss rhuss approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wait, no-wait and async flag should follow bool var CLI conventions
5 participants
@navidshaikh @knative-metrics-robot @knative-prow-robot @rhuss @googlebot