fix(plugin): Fix plugin lookup with file ext on Windows #774

dsimansk · 2020-04-02T12:27:35Z

Changes

Change plugin lookup to try to match well-know file extensions

Reference

Fixes #767

knative-prow-robot

@dsimansk: 0 warnings.

In response to this:

Changes

Change plugin lookup to try to match well-know file extensions

Reference

Fixes #767

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dsimansk · 2020-04-02T13:06:26Z

/retest

rhuss

looks good in principle but I think the error case (e.g. not-readable or other io errors) is not handled well (true for the other check in this method, too)

rhuss · 2020-04-02T13:25:52Z

pkg/kn/commands/plugin/handler.go

+		if runtime.GOOS == "windows" {
+			for _, ext := range []string{".bat", ".cmd", ".com", ".exe", ".ps1"} {
+				pathWithExt := pluginDirPluginPath + ext
+				if _, err = os.Stat(pathWithExt); !os.IsNotExist(err) {


What if err != nil but also !os.IsNotExist() is true ? (i.e. if there is an error as than not-found). The path is then returned nevertheless, which imo is wrong. (same error btw in the check above, too).

IMO this method should return (string,err) with an empy string if nothing is found, non-empty string if the plugin is found and err if any other error occured.

Also just split the os.Stat and os.IsNotExit to make logic clear

For now I've opted for less invasive solution that will only check err == nil to fix the reported issue. And also allow straightforward cherry-pick to release-0.13.

I agree that we should look closer to handler code and improve Lookup as suggested by @rhuss and anything else that will come up.

maximilien

/ok-to-test

maximilien · 2020-04-02T15:45:35Z

pkg/kn/commands/plugin/handler.go

+		if runtime.GOOS == "windows" {
+			for _, ext := range []string{".bat", ".cmd", ".com", ".exe", ".ps1"} {
+				pathWithExt := pluginDirPluginPath + ext
+				if _, err = os.Stat(pathWithExt); !os.IsNotExist(err) {


Also just split the os.Stat and os.IsNotExit to make logic clear

rhuss · 2020-04-03T11:57:02Z

pkg/kn/commands/plugin/handler.go

@@ -76,6 +76,17 @@ func (h *DefaultPluginHandler) Lookup(name string) (string, bool) {
 			return pluginDirPluginPath, true
 		}

+		// Try to match well-known file extensions on Windows


@dsimansk while we are at it, could you please also adapt the three lines above (just to be consistent) and add a comment that we should strive for a more sophisticated error handling in the future ?

Sure, will do.

rhuss

thanks !

/lgtm
/approve

knative-prow-robot · 2020-04-03T12:57:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* fix(plugin): Fix plugin lookup with file ext on Windows * chore: Update changelog * fix: Reflect review feedback * fix: Reflect review feedback and add future todo Signed-off-by: Roland Huß <roland@ro14nd.de> # Conflicts: # CHANGELOG.adoc

* (refactor) address the e2e extract / refactor of issue #763 (#765) * (refactor) address the e2e extract / refactor of issue #763 * various updates to address reviewers feedback * renamed lib/test/integration to lib/test and package to test Signed-off-by: Roland Huß <roland@ro14nd.de> # Conflicts: # CHANGELOG.adoc # test/e2e/service_export_import_apply_test.go # test/e2e/trigger_test.go * fix(plugin): Fix plugin lookup with file ext on Windows (#774) * fix(plugin): Fix plugin lookup with file ext on Windows * chore: Update changelog * fix: Reflect review feedback * fix: Reflect review feedback and add future todo Signed-off-by: Roland Huß <roland@ro14nd.de> # Conflicts: # CHANGELOG.adoc * fix(issue #762): correct error message when updating service (#778) * fix(issue #762): correct error message when updating service * correct message when updating service and passing many names * fix issue with TestServiceUpdateWithMultipleImages running create vs update * * added TestServiceDescribeWithMultipleNames * added TestServiceCreateWithMultipleNames * fix error message for service delete since many names can be passed * Use vendored deps while running e2e locally (#783) Also set GO111MODULE=on unconditionally * Update sink binding create usage string (#785) * Add "--target-utilization" to manage "autoscaling.knative.dev/targetUtilizationPercentage" annotation (#788) * Support setting "autoscaling.knative.dev/targetUtilizationPercentage" annotation. Signed-off-by: Roland Huß <roland@ro14nd.de> # Conflicts: # test/e2e/service_options_test.go * Remove the delete propagation flag (#770) * Remove the delete propagation flag In it's current state it now takes me about 25 seconds for the `kn delete` to complete. Before #682 it used to be almost immediate. This is because we now pass in the `DeletePropagationBackground` flag. I believe this is a mistake, not only because of the 20+ seconds of additional time to delete things, but IMO the CLI should talk to the server in the same way regardless of the --wait flag. That flag should just be a CLI thing to indicate if the user wants the CLI to wait for the server to complete but not HOW the server should do the delete. Signed-off-by: Doug Davis <dug@us.ibm.com> * try just tweaking the --no-wait flag Signed-off-by: Doug Davis <dug@us.ibm.com> * Fix error when output is set to name (#775) * fix error when output is set to name * add e2e test * change to flags/listprint.go Signed-off-by: Roland Huß <roland@ro14nd.de> # Conflicts: # test/e2e/basic_workflow_test.go * Show all revisions when run `service describe -v` (#790) * The `kn service describe -v` command shows repetitive revisions, because the revision would be covered by next one. * Fix resource listing with -oname flag (#799) * Fix resource listing with -oname flag * add e2e tests Signed-off-by: Roland Huß <roland@ro14nd.de> # Conflicts: # test/e2e/ping_test.go # test/e2e/revision_test.go # test/e2e/route_test.go # test/e2e/source_apiserver_test.go # test/e2e/source_binding_test.go # test/e2e/trigger_test.go * Make wait, no-wait and async flags per bool var CLI convention (#802) * Make wait, no-wait and async flags per bool var CLI convention Fixes #800 - Deprecated bool vars can be supported for CLI convention - Bind --async flag value to --no-wait - Only one flag among [wait, no-wait, async] can be provided, else raise an error * Simplify conditionals * Add unit tests for deprecated flag async * Fix a typo * e2e: Foreground delete for revisions and services in e2e (#794) * e2e: Foreground delete for revisions and services in e2e to avoid any race conditions and flakes * Use --wait instead of --no-wait=false Signed-off-by: Roland Huß <roland@ro14nd.de> # Conflicts: # test/e2e/basic_workflow_test.go # test/e2e/revision_test.go * e2e: Run tekton e2e against pipeline v0.11.1 (#803) * Use buildah task from master branch and paramterize FORMAT * Configure pipeline v0.11.1 * DNM: Run tekton e2e in this PR * Revert "DNM: Run tekton e2e in this PR" This reverts commit 903f5be. * Update CHANGELOG for v0.13.2 (#804) * Pin serving to v0.13.2 and update version command (#797) * Pin serving v0.13.2 dep to v0.13.2 * Update version command now points to serving v0.13.2 and eventing v0.13.6 * Copy go.sum as generated in CI Signed-off-by: Roland Huß <roland@ro14nd.de> # Conflicts: # go.mod # go.sum # vendor/modules.txt * add missing vendored files * fixed error reporting for traffics tests * Updated test * fix formatting * e2e for service export (#739) * e2e for service export * e2e for service export * e2e for service export * e2e for service export * e2e for service export Signed-off-by: Roland Huß <roland@ro14nd.de> # Conflicts: # test/e2e/service_export_import_apply_test.go Co-authored-by: dr.max <maxim@us.ibm.com> Co-authored-by: David Simansky <dsimansk@redhat.com> Co-authored-by: Navid Shaikh <nshaikh@redhat.com> Co-authored-by: Lv Jiawei <lvjiawei@cmss.chinamobile.com> Co-authored-by: Doug Davis <dug@us.ibm.com> Co-authored-by: Ying Chun Guo <guoyingc@cn.ibm.com> Co-authored-by: Murugappan Chetty <itsmurugappan@gmail.com>

fix(plugin): Fix plugin lookup with file ext on Windows

b664a69

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 2, 2020

knative-prow-robot reviewed Apr 2, 2020

View reviewed changes

knative-prow-robot requested review from mattmoor and navidshaikh April 2, 2020 12:27

knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2020

chore: Update changelog

d989b88

rhuss reviewed Apr 2, 2020

View reviewed changes

maximilien suggested changes Apr 2, 2020

View reviewed changes

knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 2, 2020

fix: Reflect review feedback

2d0a7bf

rhuss reviewed Apr 3, 2020

View reviewed changes

fix: Reflect review feedback and add future todo

6d28d8e

rhuss approved these changes Apr 3, 2020

View reviewed changes

knative-prow-robot assigned rhuss Apr 3, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2020

knative-prow-robot merged commit 71f8b25 into knative:master Apr 3, 2020

navidshaikh added the backport/candidate Consider this PR to be backported to the release branch label Apr 15, 2020

rhuss mentioned this pull request Apr 15, 2020

Pr/release 0.13.2 backports #806

Merged

navidshaikh added backport/pr A backport PR which is target to a release branch. and removed backport/candidate Consider this PR to be backported to the release branch labels Apr 20, 2020

rhuss added backported-to/0.13 and removed backport/pr A backport PR which is target to a release branch. labels Apr 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(plugin): Fix plugin lookup with file ext on Windows #774

fix(plugin): Fix plugin lookup with file ext on Windows #774

dsimansk commented Apr 2, 2020

knative-prow-robot left a comment

dsimansk commented Apr 2, 2020

rhuss left a comment

rhuss Apr 2, 2020

maximilien Apr 2, 2020

dsimansk Apr 3, 2020

maximilien left a comment

maximilien Apr 2, 2020

rhuss Apr 3, 2020

dsimansk Apr 3, 2020

rhuss left a comment

knative-prow-robot commented Apr 3, 2020

fix(plugin): Fix plugin lookup with file ext on Windows #774

fix(plugin): Fix plugin lookup with file ext on Windows #774

Conversation

dsimansk commented Apr 2, 2020

Changes

Reference

knative-prow-robot left a comment

Choose a reason for hiding this comment

Changes

Reference

dsimansk commented Apr 2, 2020

rhuss left a comment

Choose a reason for hiding this comment

rhuss Apr 2, 2020

Choose a reason for hiding this comment

maximilien Apr 2, 2020

Choose a reason for hiding this comment

dsimansk Apr 3, 2020

Choose a reason for hiding this comment

maximilien left a comment

Choose a reason for hiding this comment

maximilien Apr 2, 2020

Choose a reason for hiding this comment

rhuss Apr 3, 2020

Choose a reason for hiding this comment

dsimansk Apr 3, 2020

Choose a reason for hiding this comment

rhuss left a comment

Choose a reason for hiding this comment

knative-prow-robot commented Apr 3, 2020