Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the donation checklist to the repo guidelines #102

Closed
rgregg opened this issue Feb 28, 2020 · 7 comments
Closed

Add the donation checklist to the repo guidelines #102

rgregg opened this issue Feb 28, 2020 · 7 comments
Assignees

Comments

@rgregg
Copy link
Contributor

rgregg commented Feb 28, 2020

There's a nice donation checklist that a few people have used in their Issues to donate code to the Knative project. However, this template and the actions required by it are not spelled out anywhere in the repo guidelines.

We should clean that up into a documented process, instead of a shared knowledge thing.

@mattmoor
Copy link
Member

So... This actually is spelled out (as we discovered Thursday), and it's not that list :)

https://github.com/knative/community/blob/master/REPOSITORY-GUIDELINES.md#requirements-for-repository-donation

@mattmoor
Copy link
Member

I think it's worth leaving this open to make it more discoverable, but it exists.

@rgregg
Copy link
Contributor Author

rgregg commented Feb 29, 2020

I think the guidelines are insufficient, and hence why that checklist grew organically out of previous requests. E.g. there's nothing in the documented guidelines about Steering having a voice about a fit to project scope. The documented steps are a very tactical "do this than that" kind of thing, without the strategic/project elements included, which are more visible in the checklist.

I'd like to see us combine elements of the checklist into what we've documented, and ideally give that checklist in markdown that people can include in their request. Perhaps an Issue template?

@rgregg
Copy link
Contributor Author

rgregg commented Feb 29, 2020

Also, we shouldn't leave issues open to fix discoverability problems.

@mattmoor
Copy link
Member

I meant leave it open to track FIXING the discoverability issues 😉

@pmorie
Copy link
Member

pmorie commented Mar 2, 2021

I think we are close to having this closed by #151

@vaikas
Copy link
Contributor

vaikas commented Mar 18, 2021

/close

@vaikas vaikas closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants