Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix presubmit-link-check.sh #1963

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Fix presubmit-link-check.sh #1963

merged 1 commit into from
Nov 5, 2019

Conversation

adrcunha
Copy link
Contributor

@adrcunha adrcunha commented Nov 5, 2019

Run markdown_build_tests directly to:

  • fix readonly var warning
  • skip unnecessary tests

/cc @RichieEscarez

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 5, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2019
* fix readonly var warning
* skip unnecessary tests
@adrcunha
Copy link
Contributor Author

adrcunha commented Nov 5, 2019

#1963 (comment) is an example of bad link detection on presubmit (forced). Note that it doesn't block the submission, even though it is reported in the PR thead (it's not marked "required" in the checks table below).

Since this PR doesn't contain any markdown files, if you click on the details of the markdown-link-check below you'll see that it passed and states so.

/cc @eallred-google

@RichieEscarez
Copy link
Contributor

@adrcunha, the last comment links back to this PR. Im confused by what the "example" is?

@adrcunha
Copy link
Contributor Author

adrcunha commented Nov 5, 2019

@adrcunha, the last comment links back to this PR. Im confused by what the "example" is?

Apologies, the passing test removed the comment pointing to the failure. The link to Spyglass is https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/knative_docs/1963/pull-knative-docs-markdown-link-check/1191819431852904452

Copy link
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants