-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix presubmit-link-check.sh #1963
Conversation
* fix readonly var warning * skip unnecessary tests
#1963 (comment) is an example of bad link detection on presubmit (forced). Note that it doesn't block the submission, even though it is reported in the PR thead (it's not marked "required" in the checks table below). Since this PR doesn't contain any markdown files, if you click on the details of the markdown-link-check below you'll see that it passed and states so. /cc @eallred-google |
@adrcunha, the last comment links back to this PR. Im confused by what the "example" is? |
Apologies, the passing test removed the comment pointing to the failure. The link to Spyglass is https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/knative_docs/1963/pull-knative-docs-markdown-link-check/1191819431852904452 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, RichieEscarez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Run markdown_build_tests directly to:
/cc @RichieEscarez