Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sugar controller installation and uninstallation steps #5834

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

prushh
Copy link
Contributor

@prushh prushh commented Jan 26, 2024

Fixes #5826

Proposed Changes

Remove uninstall steps and yaml file from table
Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7573452
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65b434b6645abb000868b531
😎 Deploy Preview https://deploy-preview-5834--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 26, 2024
@prushh prushh changed the title fix: remove sugar controller installation and uninstallation steps Remove sugar controller installation and uninstallation steps Jan 26, 2024
@ReToCode
Copy link
Member

/assign @pierDipi

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

knative-prow bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi, prushh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@knative-prow knative-prow bot merged commit 396134f into knative:main Jan 30, 2024
19 checks passed
@matzew
Copy link
Member

matzew commented Jan 30, 2024

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@matzew: new pull request created: #5843

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Member

matzew commented Jan 30, 2024

Thanks for the PR, @prushh

prushh added a commit to prushh/docs that referenced this pull request Apr 30, 2024
Remove uninstall steps and yaml file from table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing sugar controller download yaml
5 participants