Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queue-sidecar annotations should be defined under spec.template.metad… #5867

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Feb 15, 2024

…ata.annotations

Otherwise they're not propagated to the Revision.

Proposed Changes

  • Move the annotations to the right place

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 64630b7
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65cde78e120a8d0008159988
😎 Deploy Preview https://deploy-preview-5867--knative.netlify.app/docs/serving/services/configure-requests-limits-services
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2024
@mgencur
Copy link
Contributor Author

mgencur commented Feb 15, 2024

/cc @skonto

@skonto
Copy link
Contributor

skonto commented Feb 15, 2024

/lgtm

Wrong pasting :)

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@skonto
Copy link
Contributor

skonto commented Feb 15, 2024

/approve

Copy link

knative-prow bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@knative-prow knative-prow bot merged commit dd743ec into knative:main Feb 15, 2024
19 checks passed
@dprotaso
Copy link
Member

Should we cherry pick this back to 1.13 and 1.12 branch?

@mgencur
Copy link
Contributor Author

mgencur commented Feb 16, 2024

Should we cherry pick this back to 1.13 and 1.12 branch?

Yes. I think so.

@ReToCode
Copy link
Member

/cherry-pick release-1.12

@ReToCode
Copy link
Member

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #5870

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #5871

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants