-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
queue-sidecar annotations should be defined under spec.template.metad… #5867
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc @skonto |
/lgtm Wrong pasting :) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Should we cherry pick this back to 1.13 and 1.12 branch? |
Yes. I think so. |
/cherry-pick release-1.12 |
/cherry-pick release-1.13 |
@ReToCode: new pull request created: #5870 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ReToCode: new pull request created: #5871 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ata.annotations
Otherwise they're not propagated to the Revision.
Proposed Changes