Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Kafka Source details on delivery spec #5952

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Apr 29, 2024

Proposed Changes

  • Adding Kafka Source details on delivery spec

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 29, 2024
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dd54772
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/662f786a8ac066000882c7de
😎 Deploy Preview https://deploy-preview-5952--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link

knative-prow bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@knative-prow knative-prow bot merged commit 2fc233e into knative:main Apr 29, 2024
19 checks passed
@matzew
Copy link
Member Author

matzew commented Apr 29, 2024

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@matzew: cannot checkout release-1.14: error checking out "release-1.14": exit status 1 error: pathspec 'release-1.14' did not match any file(s) known to git

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Member Author

matzew commented Apr 29, 2024

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@matzew: new pull request created: #5953

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants