-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a "Which Knative" page per Issue 5932 #6055
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this @jasonsmithio !! Would you be able to also add a section for Knative Functions into this page?
Sure, I should push it within 48 hours . |
Howdy, Update has been pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @pierDipi @Leo6Leo @dprotaso @lkingland
In case anyone has other opinions about the contents here :)
Any additional changes that you would like to see? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Sorry for the delay here @jasonsmithio
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, jasonsmithio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
"Fixes #5932
getting-images/which-knative.md