Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a "Which Knative" page per Issue 5932 #6055

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

jasonsmithio
Copy link
Contributor

"Fixes #5932

  • created getting-images/which-knative.md

Copy link

linux-foundation-easycla bot commented Jul 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d2921be
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/669d4072d184df000882b172
😎 Deploy Preview https://deploy-preview-6055--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this @jasonsmithio !! Would you be able to also add a section for Knative Functions into this page?

@jasonsmithio
Copy link
Contributor Author

Sure, I should push it within 48 hours .

@jasonsmithio
Copy link
Contributor Author

Howdy,

Update has been pushed

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @pierDipi @Leo6Leo @dprotaso @lkingland

In case anyone has other opinions about the contents here :)

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
@jasonsmithio
Copy link
Contributor Author

Any additional changes that you would like to see?

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Sorry for the delay here @jasonsmithio

Copy link

knative-prow bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, jasonsmithio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@knative-prow knative-prow bot merged commit 9919c40 into knative:main Aug 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the best use case example for different Knative Features
2 participants