Remove legacy code #532

scothis · 2018-10-19T18:54:32Z

Proposed Changes

remove API groups:

channels.knative.dev
feeds.knative.dev
flows.knative.dev

Remove code and dependencies that depended directly on those API groups.
This includes all Buses and EventSources.

Where practical references to Channel and Subscription in
channels.knative.dev have been updated to eventing.knative.dev.

The e2e suite has been decimated and will need to be reestabilished.

Removed vendor dependencies for Samara (Kafka) and Cloud Pub/Sub.

Updated release script. Now publishes three artifacts:

eventing.yaml - core of eventing
in-memory-channel.yaml - in memory channel provisioner
release.yaml - eventing core + in memory provisioner

Release Note

All existing EventSources and Buses are no longer supported.

knative-prow-robot · 2018-10-19T18:54:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: scothis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [scothis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

scothis · 2018-10-19T18:55:11Z

/hold

I wanted to see what the repo would look like if we removed all legacy code. I'm not sure if it is a good idea to merge this PR or not.

scothis · 2018-10-22T16:07:53Z

/assign @vaikas-google

I want to allow plenty of time for people to yell if they think we should persevere the old and new worlds side-by-side. I'm currently leaning towards a clean slate.

As a bonus, it should help our coverage stats.

n3wscott · 2018-10-22T16:10:45Z

we need to keep all of this around until the samples can be rewritten in knative/docs

evankanderson · 2018-10-22T17:16:19Z

+1 to @n3wscott I'd rather remove this once we have at least one working new example, assuming that our current docs are pointing at our HEAD releases, rather than a release branch that no one remembers creating. :-D

…

On Mon, Oct 22, 2018 at 9:10 AM Scott Nichols ***@***.***> wrote: we need to keep all of this around until the samples can be rewritten in knative/docs — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#532 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHlyN_IL3wzKi64AnJWOl6zhuge3JfVbks5une4LgaJpZM4XxPfA> .

-- Evan Anderson <argent@google.com>

scothis · 2018-10-23T16:02:54Z

Each of the samples in knative/docs uses a source, which has moved to knative/eventing-sources. I can submit a PR that removes all of the eventing samples since they will each need to be significantly updated to the point where it's essentially a new sample.

Another option is to cut a 0.1 release with what's in the repo today, pin the current samples against that and then focus all of our effort on 0.2. There would be zero backwards compatibility between 0.1 and 0.2.

evankanderson · 2018-10-23T17:14:55Z

If we've moved the sources to eventing-sources and are including the current Sources there, then I think we can delete these after the following steps: 1. Make sure that we are generating release builds & yaml (nightly) for eventing-sources. 2. Update the docs to point to the releases from point 1 3. Submit this PR. I know that we've been steering people away from using eventing to some extent, but I'd like to have the docs still be in a working shape for the old setup until we have the new Channel & Provisioner working for in-memory at least (which should be fairly soon, I think).

…

On Tue, Oct 23, 2018 at 9:10 AM Scott Andrews ***@***.***> wrote: Each of the samples in knative/docs uses a source, which has moved to knative/eventing-sources. I can submit a PR that removes all of the eventing samples since they will each need to be significantly updated to the point where it's essentially a new sample. Another option is to cut a 0.1 release with what's in the repo today, pin the current samples against that and then focus all of our effort on 0.2. There would be zero backwards compatibility between 0.1 and 0.2. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#532 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHlyNylKj7wELruBqIwrJJ-ukVjzL2xoks5unz-HgaJpZM4XxPfA> .

-- Evan Anderson <argent@google.com>

vaikas · 2018-10-24T00:04:12Z

+1 I'd like to get to a state where our existing samples (or an agreed upon subset of them) actually work end-to-end with the new stuff and our docs refer to them. I'm very supportive of this PR but want to make sure we have some sort of continuity when moving towards the new object model.

vaikas · 2018-11-06T01:02:55Z

Fixes #582

remove API groups: - channels.knative.dev - feeds.knative.dev - flows.knative.dev Remove code and dependencies that depended directly on those API groups. This includes all Buses and EventSources. Where practical references to Channel and Subscription in channels.knative.dev have been updated to eventing.knative.dev. The e2e suite has been decimated and will need to be reestabilished.

vaikas · 2018-11-06T20:19:47Z

test/crd_checks.go

@@ -23,8 +23,8 @@ import (
 	"fmt"
 	"time"

-	eventingV1alpha1 "github.com/knative/eventing/pkg/apis/eventing/v1alpha1"
-	eventingtyped "github.com/knative/eventing/pkg/client/clientset/versioned/typed/eventing/v1alpha1"
+	flowsV1alpha1 "github.com/knative/eventing/pkg/apis/flows/v1alpha1"


This seems wrong?

vaikas · 2018-11-06T20:22:36Z

test/image_paths.txt

this seems to need to go away?

vaikas · 2018-11-06T20:22:48Z

test/states.go

@@ -16,7 +16,7 @@ limitations under the License.
 package test

 import (
-	eventingV1alpha1 "github.com/knative/eventing/pkg/apis/eventing/v1alpha1"
+	flowsV1alpha1 "github.com/knative/eventing/pkg/apis/flows/v1alpha1"


this seems wrong?

knative-metrics-robot · 2018-11-06T20:48:48Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/controller/main.go	3.3%	4.9%	1.6

grantr

🎉 Thanks for working through all this @scothis!

(I only reviewed hack/release.sh)

grantr · 2018-11-06T21:10:52Z

hack/release.sh

@@ -23,23 +23,15 @@ readonly EVENTING_RELEASE_GCS
 readonly EVENTING_RELEASE_GCR

 # Yaml files to generate, and the source config dir for them.
+declare -A COMPONENTS
+COMPONENTS["eventing.yaml"]="config"
+COMPONENTS["in-memory-channel.yaml"]="config/provisioners/in-memory-channel"


Won't this duplicate the config that's already in eventing.yaml, since that file contains this directory also? Then the release yaml will have two copies of the in-memory-channel objects.

@grantr There will be three files produced for the release:

eventing.yaml only knative eventing

in-memory-channel.yaml only the in-memory provisioner

release.yaml eventing.yaml + in-memory-channel.yaml

When you give a directory to ko, it will only build config files that are in that exact directory.

I ran this script with my own creds when I originally put up the PR.

👍 Thanks, TIL. Apparently there's a --recursive flag to kubectl that selects the behavior I was expecting.

Minor preference for core.yaml or eventing-core.yaml over eventing.yaml, but this is fine for now.

/hold cancel

This is the patten that serving uses, but it's easy enough to change.

vaikas · 2018-11-06T21:13:43Z

Good with everything except the release script, letting @grantr unhold once release is right, everything else is lgtm.
/lgtm
/hold

adrcunha · 2018-11-07T02:34:41Z

hack/release.sh

+    echo "# ${component}" >> ${yaml}
+    cat ${component} >> ${yaml}
+  done
+  all_yamls+=(${yaml})


You missed tagging the images here (line 79 in the original code). This is a bug. :(

@adrcunha is it necessary to run tag_images_in_yaml again? This step is only concatenating yamls generated above which were tagged here.

Yes. In line 62 you were tagging the component yamls. Now you're tagging the release yamls. Because on line 88 you're publishing all yamls (components and releases).

(sorry, this fell off my radar)

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 19, 2018

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2018

knative-prow-robot requested review from adrcunha, grantr and steuhs October 19, 2018 18:54

knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 19, 2018

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2018

knative-prow-robot assigned vaikas Oct 22, 2018

This was referenced Oct 26, 2018

K8seventsource knative/eventing-contrib#38

Merged

using cloud events for the sample heartbeat knative/eventing-contrib#27

Merged

This was referenced Oct 29, 2018

Move eventing/pkg/events to pkg/ ? knative/eventing-contrib#45

Closed

Move cloudevents lib out of eventing. #578

Merged

scothis added 3 commits November 6, 2018 12:40

Fix release script

29d2321

maybe allow e2e tests to pass

e3058cd

scothis force-pushed the bring-out-your-dead branch from 95f5103 to e3058cd Compare November 6, 2018 17:55

scothis added 2 commits November 6, 2018 14:46

ClusterProvisioner -> ClusterChannelProvisioner in e2etests

44e1945

Use e2e tests from master

f78159f

vaikas reviewed Nov 6, 2018

View reviewed changes

scothis added 2 commits November 6, 2018 15:30

Remove deleted image paths for e2e tests

de1a227

pune more dead code

7aa9f75

grantr reviewed Nov 6, 2018

View reviewed changes

knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 6, 2018

knative-prow-robot merged commit 111089f into knative:master Nov 6, 2018

scothis deleted the bring-out-your-dead branch November 6, 2018 22:19

adrcunha reviewed Nov 7, 2018

View reviewed changes

pierDipi pushed a commit to pierDipi/eventing that referenced this pull request Feb 26, 2024

[release-v1.11] backport receiver trace step annotation (knative#532)

e0570d8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove legacy code #532

Remove legacy code #532

scothis commented Oct 19, 2018 •

edited

Loading

knative-prow-robot commented Oct 19, 2018

scothis commented Oct 19, 2018

scothis commented Oct 22, 2018

n3wscott commented Oct 22, 2018

evankanderson commented Oct 22, 2018 via email

scothis commented Oct 23, 2018

evankanderson commented Oct 23, 2018 via email

vaikas commented Oct 24, 2018

vaikas commented Nov 6, 2018

vaikas Nov 6, 2018

vaikas Nov 6, 2018

vaikas Nov 6, 2018

knative-metrics-robot commented Nov 6, 2018

grantr left a comment

grantr Nov 6, 2018

scothis Nov 6, 2018 •

edited

Loading

grantr Nov 6, 2018

scothis Nov 6, 2018

vaikas commented Nov 6, 2018

adrcunha Nov 7, 2018

scothis Nov 7, 2018

adrcunha Nov 20, 2018

adrcunha Nov 20, 2018

Remove legacy code #532

Remove legacy code #532

Conversation

scothis commented Oct 19, 2018 • edited Loading

Proposed Changes

knative-prow-robot commented Oct 19, 2018

scothis commented Oct 19, 2018

scothis commented Oct 22, 2018

n3wscott commented Oct 22, 2018

evankanderson commented Oct 22, 2018 via email

scothis commented Oct 23, 2018

evankanderson commented Oct 23, 2018 via email

vaikas commented Oct 24, 2018

vaikas commented Nov 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

knative-metrics-robot commented Nov 6, 2018

grantr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scothis Nov 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vaikas commented Nov 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scothis commented Oct 19, 2018 •

edited

Loading

scothis Nov 6, 2018 •

edited

Loading