Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cloudevents lib out of eventing. #578

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Move cloudevents lib out of eventing. #578

merged 1 commit into from
Nov 2, 2018

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Nov 2, 2018

Proposed Changes

  • use the cloud events lib that is now in knative/pkg

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 2, 2018
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 2, 2018
@n3wscott
Copy link
Contributor Author

n3wscott commented Nov 2, 2018

/assign @grantr
/cc @scothis

@grantr
Copy link
Contributor

grantr commented Nov 2, 2018

knative/pkg#154 moved this to knative/pkg.

@n3wscott
Copy link
Contributor Author

n3wscott commented Nov 2, 2018

also related: #532

grantr
grantr approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This change allows eventing-sources to be independent of eventing, making both repos easier to package into releases (together or separate).

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@knative-prow-robot knative-prow-robot merged commit 370145f into knative:master Nov 2, 2018
@matzew
Copy link
Member

matzew commented Nov 5, 2018

ah, this is nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantr grantr grantr approved these changes

@inlined inlined Awaiting requested review from inlined

@srinivashegde86 srinivashegde86 Awaiting requested review from srinivashegde86

@scothis scothis Awaiting requested review from scothis

Assignees

@grantr grantr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@n3wscott @grantr @knative-prow-robot @matzew @googlebot