[WIP] feat: add --pvc-size flag to deploy command (#851)

[grafvonb]

Ref: #851

[codecov]

Codecov Report

Patch coverage: 76.66% and project coverage change: +0.30 🎉

Comparison is base (c20c887) 60.26% compared to head (9909953) 60.57%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1543      +/-   ##
==========================================
+ Coverage   60.26%   60.57%   +0.30%     
==========================================
  Files          75       76       +1     
  Lines       10308    10330      +22     
==========================================
+ Hits         6212     6257      +45     
+ Misses       3524     3500      -24     
- Partials      572      573       +1     

Flag	Coverage Δ
integration-tests	50.93% <76.66%> (-0.01%)	⬇️
unit-tests	?
unit-tests-macos-latest	49.48% <76.66%> (?)
unit-tests-ubuntu-latest	50.99% <76.66%> (?)
unit-tests-windows-latest	49.38% <76.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/functions/function.go	83.67% <ø> (+0.34%)	⬆️
pkg/pipelines/tekton/pipeplines_provider.go	14.66% <42.85%> (+0.13%)	⬆️
cmd/deploy.go	68.48% <86.95%> (+0.02%)	⬆️
pkg/knative/logs.go	80.41% <0.00%> (-4.13%)	⬇️
pkg/docker/docker_client_nonlinux.go	0.00% <0.00%> (ø)
pkg/functions/client.go	59.21% <0.00%> (+0.55%)	⬆️
pkg/docker/creds/credentials.go	73.06% <0.00%> (+1.34%)	⬆️
pkg/docker/docker_client.go	84.87% <0.00%> (+23.52%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[matejvasek]

@grafvonb out of curiosity have you encounter problems with the default size for some builds?

[grafvonb]

@grafvonb out of curiosity have you encounter problems with the default size for some builds?

Hi, I will test it extensively on AWS for different tech stacks when I am ready, but the version I pushed in this feature branch already works (I want to change the error handling for the parameter and add tests).

However, I have already made interesting observations, for example, the default size of a pvc defined in the gp2 storage class cannot be overwritten with a lower value (so the default value is actually the minimum value). Thus, our default value of 256Mi does not result in the creation of a pvc with that size on AWS. Instead, it creates a pvc with 1Gi, which is the default value for gp2 in AWS (unless explicitly changed by the administrator). I also tried a deployment with the value --pvc-size=2Gi and it was created as expected.

[matejvasek]

@grafvonb this needs rebase.

[knative-prow-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grafvonb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment