DO NOT MERGE YET: testing CI #49
Conversation
|
@lkingland trying to run CI on multiple OSes. |
|
@lkingland there are few tests failing because of file mods (access perms.); I am not sure how we could fix this. |
| @@ -23,50 +23,50 @@ func TestPathToDomain(t *testing.T) { | |||
| {"", noLimit, ""}, | |||
|
|
|||
| // trailing slashes ignored | |||
| {"/home/user/example.com/admin/", noLimit, "admin.example.com"}, | |||
| {"/home" + string(os.PathSeparator) + "user" + string(os.PathSeparator) + "example.com" + string(os.PathSeparator) + "admin/", noLimit, "admin.example.com"}, | |||
There was a problem hiding this comment.
This might be cleaner as filepath.Join(...)
| strategy: | ||
| matrix: | ||
| os: ['ubuntu-latest', 'windows-latest', 'macos-latest'] | ||
| runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
I love that we are dipping our toes in here, but I would caution that we don't spend too much time on cross-compatibility until we're past v1, or we risk spending a lot of time in maintenance of platforms not in active use.
There was a problem hiding this comment.
Although I would say that OSX and Linux are must-have...
Sounds like a bug in pkger to me. I created a new issue #57 |
I think this test could be changed to be OS agnostic. And this test could check |
|
@matejvasek this PR is now pointing to the incorrect main branch ( |
No description provided.