Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag images using ko #393

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Tag images using ko #393

merged 1 commit into from
Aug 14, 2024

Conversation

upodroid
Copy link
Member

#389 introduced a bug. The code I deleted in that PR was adding the git tags to the docker images. Now the git tag is passed to ko directly.

Tested with operator at https://console.cloud.google.com/artifacts/docker/knative-nightly/us/gcr.io/knative.dev%2Foperator%2Fcmd%2Foperator?project=knative-nightly

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2024
cardil
cardil approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 06f7aff into knative:main Aug 14, 2024
6 checks passed
@dprotaso
Copy link
Member

/cherry-pick release-1.15

@dprotaso
Copy link
Member

/cherry-pick release-1.14

@knative-prow-robot
Copy link

@dprotaso: new pull request created: #394

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 14, 2024
Merged
@knative-prow-robot
Copy link

@dprotaso: new pull request created: #395

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardil cardil cardil approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@cardil cardil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upodroid @dprotaso @knative-prow-robot @cardil