Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option to install net-certmanager-controller #950

Closed
gecube opened this issue Feb 7, 2022 · 8 comments
Closed

No option to install net-certmanager-controller #950

gecube opened this issue Feb 7, 2022 · 8 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/serving lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@gecube
Copy link

gecube commented Feb 7, 2022

Hello!

I'd like to completely manage the Knative installation with the operator. It is easy and nice. But in fact I didn't find any option to install net-certmanager-controller component of Knative with the operator. It looks like that this component may be installed only with optional manifest https://github.com/knative/net-certmanager/releases/download/knative-v1.2.0/release.yaml
It makes me very sad, because I need to use two completely different ways to manage the configuration of Knative.
Please add the net-certmanager-controller to operator.

@gecube gecube added the kind/bug Categorizes issue or PR as related to a bug. label Feb 7, 2022
@houshengbo
Copy link
Contributor

@gecube net-certmanager is not the core of knative, so far it is installed by the additional manifests.

@gecube
Copy link
Author

gecube commented Feb 8, 2022

It is sad to hear it :-( I thought it will be relatively ease to make a switch (toggle) in operator to install or not this component.

@houshengbo
Copy link
Contributor

houshengbo commented Feb 8, 2022

So far to use the net-cert with the operator, you have to use the CR as follows:

apiVersion: v1
kind: Namespace
metadata:
 name: knative-serving
---
apiVersion: operator.knative.dev/v1alpha1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  version: "1.2"
  additionalManifests:
    - URL: https://github.com/knative-sandbox/net-certmanager/releases/download/knative-v1.2.0/net-certmanager.yaml

Operator cannot cover everything with the spec. That was why we enabled custom manifests as an option to install literally anything with spec.additionalManifests.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 10, 2022
@github-actions github-actions bot closed this as completed Jun 9, 2022
@dprotaso
Copy link
Member

/lifecycle frozen

@dprotaso dprotaso reopened this Nov 15, 2023
@knative-prow knative-prow bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2023
@dprotaso
Copy link
Member

Similar to how we install our net-istio and net-contour it would be nice if the operator provided facilities to install net-certmanager

@ReToCode
Copy link
Member

ReToCode commented Jun 4, 2024

This is no longer needed, as net-certmanager is now integrated into Serving.

/close

@knative-prow knative-prow bot closed this as completed Jun 4, 2024
Copy link

knative-prow bot commented Jun 4, 2024

@ReToCode: Closing this issue.

In response to this:

This is no longer needed, as net-certmanager is now integrated into Serving.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/serving lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Development

No branches or pull requests

4 participants