Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] manual back-port of https://github.com/knative/operator/pull/1548 #1576

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Oct 2, 2023

Proposed Changes

Release Note

The operator now sets HorizontalPodAutoscaler replicas (on resources with HPAs) when workload overrides are defined.

* set HPA replica values when workload overrides are set

* add mapping for HPAs that are named differently to their target

* add more test cases

* rename deployment override to workload override

(cherry picked from commit dc4be00)
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 2, 2023
@ReToCode ReToCode changed the title Manual back-port of https://github.com/knative/operator/pull/1548 [release-1.11] manual back-port of https://github.com/knative/operator/pull/1548 Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a957149) 79.22% compared to head (8c4bd7d) 79.23%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11    #1576      +/-   ##
================================================
+ Coverage         79.22%   79.23%   +0.01%     
================================================
  Files                40       41       +1     
  Lines              1800     1830      +30     
================================================
+ Hits               1426     1450      +24     
- Misses              272      276       +4     
- Partials            102      104       +2     
Files Coverage Δ
pkg/reconciler/common/transformers.go 82.60% <100.00%> (ø)
pkg/reconciler/common/ha.go 77.77% <80.00%> (+13.77%) ⬆️
pkg/reconciler/common/workload_override.go 84.61% <72.72%> (-1.10%) ⬇️
pkg/reconciler/common/hpa.go 65.90% <65.90%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member Author

ReToCode commented Oct 2, 2023

/assign @pierDipi
/assign @skonto
/assign @nak3

@nak3
Copy link
Contributor

nak3 commented Oct 2, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2023
@ReToCode
Copy link
Member Author

ReToCode commented Oct 2, 2023

/assign @houshengbo

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2023
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, pierDipi, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e70b4a6 into knative:release-1.11 Oct 2, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants