-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.11] manual back-port of https://github.com/knative/operator/pull/1548 #1576
[release-1.11] manual back-port of https://github.com/knative/operator/pull/1548 #1576
Conversation
* set HPA replica values when workload overrides are set * add mapping for HPAs that are named differently to their target * add more test cases * rename deployment override to workload override (cherry picked from commit dc4be00)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-1.11 #1576 +/- ##
================================================
+ Coverage 79.22% 79.23% +0.01%
================================================
Files 40 41 +1
Lines 1800 1830 +30
================================================
+ Hits 1426 1450 +24
- Misses 272 276 +4
- Partials 102 104 +2
☔ View full report in Codecov by Sentry. |
bfe1684
to
8c4bd7d
Compare
/lgtm |
/assign @houshengbo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, pierDipi, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
hack/update-codegen.sh
Release Note