Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [release-v1.10] Support Eventing TLS #1585

Closed
wants to merge 5 commits into from
Closed

[WIP] [release-v1.10] Support Eventing TLS #1585

wants to merge 5 commits into from

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 9, 2023 •
edited
Loading

Cherry-pick of #1582

@pierDipi
Handle TLS resources based on feature flag value
3920960 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Fetch eventing-tls-networking.yaml file
99d1ea6 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Handle NoKind error and add permissions to operator
948b20c 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Fix license header
d1b404a 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Run hack/update-codegen.sh
cff5edb 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 9, 2023
@pierDipi pierDipi changed the base branch from main to release-1.10 October 9, 2023 06:58
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2023
@pierDipi pierDipi changed the title [release-v1.10Support Eventing TLS [release-v1.10] Support Eventing TLS Oct 9, 2023
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 9, 2023
@pierDipi pierDipi requested a review from creydr October 9, 2023 06:59
@pierDipi
Copy link
Member Author

pierDipi commented Oct 9, 2023

Those jobs failures are unrelated, I wrongly clicked and it opened a PR against main but it was meant to be against release-1.10

@knative-prow
Copy link

knative-prow bot commented Oct 9, 2023

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
serving-upgrade-tests_operator_main cff5edb link true /test serving-upgrade-tests
eventing-upgrade-tests_operator_main cff5edb link true /test eventing-upgrade-tests
build-tests_operator_main cff5edb link true /test build-tests
unit-tests_operator_main cff5edb link true /test unit-tests
integration-tests_operator_main cff5edb link true /test integration-tests
upgrade-tests_operator_main cff5edb link true /test upgrade-tests
upgrade-tests_operator_release-1.10 cff5edb link true /test upgrade-tests
eventing-upgrade-tests_operator_release-1.10 cff5edb link true /test eventing-upgrade-tests
integration-tests_operator_release-1.10 cff5edb link true /test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierDipi pierDipi changed the title [release-v1.10] Support Eventing TLS [WIP] [release-v1.10] Support Eventing TLS Oct 9, 2023
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@pierDipi pierDipi closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok Awaiting requested review from aliok

@houshengbo houshengbo Awaiting requested review from houshengbo

@creydr creydr Awaiting requested review from creydr

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierDipi @knative-prow-robot