Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Add knativeeventing extra again #1588

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1587

It was inadvertently removed in [1].

[1] knative@6e5a006

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2023
Copy link
Contributor

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0c6e47b) 79.23% compared to head (1827f9c) 79.23%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.11    #1588   +/-   ##
=============================================
  Coverage         79.23%   79.23%           
=============================================
  Files                41       41           
  Lines              1830     1830           
=============================================
  Hits               1450     1450           
  Misses              276      276           
  Partials            104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member

pierDipi commented Oct 9, 2023

/test eventing-upgrade-tests

@knative-prow knative-prow bot merged commit 4525683 into knative:release-1.11 Oct 9, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants