Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Audience field in duckv1.Destination #2796

Closed
creydr opened this issue Aug 16, 2023 · 5 comments · Fixed by #2797
Closed

Add Audience field in duckv1.Destination #2796

creydr opened this issue Aug 16, 2023 · 5 comments · Fixed by #2797
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Aug 16, 2023

As the Eventing OIDC feature track describes, the Destination type allows to reference Addressable resources, raw Kubernetes services or absolute URLs. As for Addressables, it is necessary to additionally specify the required audience for those services.

Therefor the Destination type needs to allow to additionally specify the destinations Audience:

type Destination struct {

	...

	// Audience is the OIDC audience. 
	// This need only be set, if the target is not an Addressable 
	// and thus the Audience can't be received from the Addressable itself.
	// In case the Addressable specifies an Audience too, the Destinations
	// Audience takes preference.
	// +optional
	Audience *string `json:"audience,omitempty"`
}

Additional context (optional)

/good-first-issue

@creydr creydr added the kind/TBD Parked issue that required triaging/revisit in a near future. label Aug 16, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 16, 2023

@creydr:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

As the Eventing OIDC feature track describes, the Destination type allows to reference Addressable resources, raw Kubernetes services or absolute URLs. As for Addressables, it is necessary to additionally specify the required audience for those services.

Therefor the Destination type needs to allow to additionally specify the destinations Audience:

type Destination struct {

 ...

  // Audience is the OIDC audience. 
 // This need only be set, if the target is not an Addressable 
 // and thus the Audience can't be received from the Addressable itself.
 // In case the Addressable specifies an Audience too, the Destinations
 // Audience takes preference.
 // +optional
  Audience *string `json:"audience,omitempty"`
}

Additional context (optional)

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 16, 2023
@abhijeetgauravm
Copy link
Contributor

I would like to work on it!

@creydr
Copy link
Member Author

creydr commented Aug 17, 2023

Hi @abhijeetgauravm,
Glad to hear you want to contribute. I am currently creating the tasks for the OIDC implementation in Knative Eventing.
Just a side note: Not all of the created issues might contain all the needed information right now or might be reworked and need to be triaged (that's the reason why I marked them as DRAFT or added the kind/TBD label). But this issue looks fine I guess.

@abhijeetgauravm
Copy link
Contributor

Can I fix it?

@creydr
Copy link
Member Author

creydr commented Aug 17, 2023

Sure, just assign the issue to you and go ahead.

@creydr creydr removed the kind/TBD Parked issue that required triaging/revisit in a near future. label Aug 17, 2023
@creydr creydr changed the title [DRAFT] Add Audience field in duckv1.Destination Add Audience field in duckv1.Destination Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
2 participants