Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from OpenCensus to OpenTelemetry #855

Open
anniefu opened this issue Nov 7, 2019 · 10 comments
Open

Migrate from OpenCensus to OpenTelemetry #855

anniefu opened this issue Nov 7, 2019 · 10 comments
Labels
area/monitoring kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@anniefu
Copy link
Contributor

anniefu commented Nov 7, 2019

OpenCensus & OpenTracing have merged to form OpenTelemetry (see https://github.com/census-instrumentation/opencensus-go & https://medium.com/opentracing/a-roadmap-to-convergence-b074e5815289).

Knative should to move to instrumenting metrics and traces with OpenTelemetry instead of OpenCensus ahead of OpenCensus getting deprecated.

@knative-prow-robot knative-prow-robot added area/monitoring kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature labels Nov 7, 2019
@grantr
Copy link
Contributor

grantr commented May 11, 2020

Looks like OpenTelemetry Go SDK is in beta now: https://github.com/open-telemetry/opentelemetry-go

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2020
@vagababov
Copy link
Contributor

/lifecycle frozen
/assign @evankanderson @jjzeng-seattle

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2020
@knative-prow-robot knative-prow-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Aug 24, 2020
@skonto
Copy link
Contributor

skonto commented Feb 17, 2021

I have done an evaluation on this topic here are the takeaways. From my POV otel is not ready yet, I would wait for GA. There is also a spike for this in wip status. We discussed this on a community meeting as well.

@evankanderson
Copy link
Member

/unassign

@evankanderson
Copy link
Member

/unassign @jjzeng-seattle

@dprotaso
Copy link
Member

FYI - there's a bridge for OpenCensus => OpenTelemetry

So we can use the OTel exporters and slowly transition the API usage over

https://github.com/open-telemetry/opentelemetry-go/tree/main/bridge/opencensus#user-journey

I think tracing would be the best POC to test this out with

@dprotaso
Copy link
Member

dprotaso commented May 24, 2023

FYI - Bug in metrics/otelhttp handler causes high cardinality
open-telemetry/opentelemetry-go-contrib#3765 - fixed in open-telemetry/opentelemetry-go-contrib#4277

@dprotaso
Copy link
Member

When performing the migration we should consider how we name the service -

The suggestion here is that hostname is not a good one because it changes as pods come up and down - knative/serving#14075

@skonto
Copy link
Contributor

skonto commented Oct 6, 2023

Otel go sdk i snow stable wrt metrics. See knative/serving#14486 for pointers. We should define a plan on how to work on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

8 participants